Re: [PATCH v2 13/13] ls: use ~0 for FILE_SIZE_STREAM

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 12/9/25 1:51 PM, Sascha Hauer wrote:
> For stream size files we used to show ((loff_t) -1) as file size which
> is quite unreadable. Use ~0 in this case.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  commands/ls.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/commands/ls.c b/commands/ls.c
> index 1ccd44f7bbc00a03b773b56020a7117ce94b24cd..5c9e0f738b03ae36655b04ec1037811a4abc0423 100644
> --- a/commands/ls.c
> +++ b/commands/ls.c
> @@ -33,8 +33,12 @@ static void ls_one(const char *path, const char* fullname)
>  		return;
>  
>  	mkmodestr(s.st_mode, modestr);
> -	printf("%s %*llu %*.*s", modestr, SIZELEN, s.st_size, namelen,
> -	       namelen, path);
> +	if (s.st_size == FILE_SIZE_STREAM)
> +		printf("%s %*s %*.*s", modestr, SIZELEN, "~0", namelen,
> +		       namelen, path);
> +	else
> +		printf("%s %*llu %*.*s", modestr, SIZELEN, s.st_size, namelen,
> +			namelen, path);
>  
>  	if (S_ISLNK(s.st_mode)) {
>  		char realname[PATH_MAX];
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |