From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mickerik.phytec.de ([195.145.39.210]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1icqri-000567-Ce for barebox@lists.infradead.org; Thu, 05 Dec 2019 13:08:19 +0000 References: <1575380921-160915-1-git-send-email-s.riedmueller@phytec.de> <20191205080755.nc2ao3hjb5eli7ud@pengutronix.de> <67c1cd67-9156-9e43-2be4-b3502877d95f@pengutronix.de> From: =?UTF-8?Q?Stefan_Riedm=c3=bcller?= Message-ID: Date: Thu, 5 Dec 2019 14:08:16 +0100 MIME-Version: 1.0 In-Reply-To: <67c1cd67-9156-9e43-2be4-b3502877d95f@pengutronix.de> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] ARM: dts: imx6qdl: phycore: Remove emmc vmmc-supply To: barebox@lists.infradead.org Hi, On 05.12.19 09:37, Ahmad Fatoum wrote: > Hello, > > On 12/5/19 9:07 AM, Sascha Hauer wrote: >> On Tue, Dec 03, 2019 at 02:48:41PM +0100, Stefan Riedmueller wrote: >>> There is no driver for the eMMC's vmmc-supply regulator in the barebox. >>> Use a dummy regulator instead by simply deleting the vmmc-supply >>> property. >>> >>> Signed-off-by: Stefan Riedmueller >>> --- >>> arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi >>> index 69f252b42382..974e271f453d 100644 >>> --- a/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi >>> +++ b/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi >>> @@ -112,6 +112,7 @@ >>> }; >>> >>> &usdhc4 { >>> + /delete-property/ vmmc-supply; >> >> I don't like this approach very much. It's fine for barebox, but leads >> to problems once you start Linux with the barebox device tree. I'd >> rather go with the unmodified device trees (apart from the things >> barebox changes to the device trees in order to start Linux). > > How about a barebox,regulator-always-on property? If the regulator is unnecessary, > it basically means you can assume it's always on when barebox runs. > > If regulator_get is called with a property that points to such a node, a dummy > regulator is returned with which enable is a no-op. Additionally, do the same > for regulator-always-on, so the in-barebox device tree only needs to mark > non regulator-always-on that are expected to be always on when it runs due to > strapping/fuses as barebox,regulator-always-on. What about regulators that are marked as regulator-always-on but need voltage adjustments? Or isn't this a real use case for the bootloader? Regards, Stefan > > Thoughts? > Ahmad > _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox