mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Daniel Glöckner" <dg@emlix.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>,
	Edmund Henniges <eh@emlix.com>
Subject: Re: [PATCH 20/20] fastboot net: remove may_send
Date: Mon, 15 Jun 2020 18:36:36 +0200	[thread overview]
Message-ID: <bbfa7ccc-8a6d-5bed-c610-ce34d9611d33@emlix.com> (raw)
In-Reply-To: <20200526060235.GT11869@pengutronix.de>

Hello Sascha,

Am 26.05.20 um 08:02 schrieb Sascha Hauer:
> On Mon, May 25, 2020 at 09:45:49PM +0200, Daniel Glöckner wrote:
>> I know that Barebox will get stuck when the host stops talking to us
>> before we had the opportunity to send the final OKAY, but that is not
>> what you describe. If you use a sleep 100, the host will time out
>> before the sleep is done. After the sleep the command is still in
>> fbn->command, so it will be acked and executed. Since the host no
>> longer talks to us, it will not send us an empty packet with the next
>> sequence number, so the loop in fastboot_write_net will never terminate.
>>
>> The only way to get out of this situation with the current code
>> (omitting patch 20) is to start a new fastboot session. The INIT packet
>> of the new session will set reinit to true, which discards all messages
>> the old session wants to send. If this is not acceptable, I suggest
>> adding a timeout >= 60 seconds to that loop in fastboot_write_net and
>> setting reinit when it expires. We can make the timeout a kconfig option
>> which defaults to 60 if you prefer.
> 
> Yes, we should add a timeout to this loop. Being stuck in an endless
> loop never is a good user experience. How about this?

In this special case setting reinit might have been enough (because
active_download must be false when we want to send a message while
may_send == MAY_NOT_SEND, fastboot.active doesn't really matter, and
command[0] will be cleared once we exit from fastboot_exec_cmd), but
there were other situations that didn't correctly handle connection
timeout/abort. That's why I reworked and unified these parts.

I liked your idea of printing a message every 5 seconds and integrated
it almost unchanged.

Patch series follows in a moment.

Best regards,

  Daniel

-- 
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11,
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke
Ust-IdNr.: DE 205 198 055

emlix - your embedded linux partner

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-06-15 16:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25 10:33 [PATCH v2 00/20] Slices and fastboot over UDP Sascha Hauer
2020-05-25 10:33 ` [PATCH 01/20] poller: Give pollers a name Sascha Hauer
2020-05-25 10:33 ` [PATCH 02/20] poller: Add a poller command Sascha Hauer
2020-05-25 10:33 ` [PATCH 03/20] fastboot: split generic code from USB gadget Sascha Hauer
2020-05-25 10:33 ` [PATCH 04/20] fastboot: don't close fd 0 when downloading to ram Sascha Hauer
2020-05-25 10:33 ` [PATCH 05/20] fastboot: Use unique tempfile name Sascha Hauer
2020-05-25 10:33 ` [PATCH 06/20] Introduce slices Sascha Hauer
2020-05-25 10:33 ` [PATCH 07/20] Introduce idle slice Sascha Hauer
2020-05-25 10:33 ` [PATCH 08/20] net: Add a slice to struct eth_device Sascha Hauer
2020-05-25 10:33 ` [PATCH 09/20] net: mdiobus: Add slice Sascha Hauer
2020-05-25 10:33 ` [PATCH 10/20] usb: Add a slice to usb host controllers Sascha Hauer
2020-05-25 10:33 ` [PATCH 11/20] usbnet: Add slice Sascha Hauer
2020-05-25 10:33 ` [PATCH 12/20] net: Call net_poll() in a poller Sascha Hauer
2020-05-25 10:33 ` [PATCH 13/20] net: reply to ping requests Sascha Hauer
2020-05-25 10:33 ` [PATCH 14/20] usbnet: Be more friendly in the receive path Sascha Hauer
2020-05-25 10:33 ` [PATCH 15/20] poller: Allow to run pollers inside of pollers Sascha Hauer
2020-05-25 10:33 ` [PATCH 16/20] defconfigs: update renamed fastboot options Sascha Hauer
2020-05-25 10:33 ` [PATCH 17/20] globalvar: Add helper for deprecated variable names Sascha Hauer
2020-05-25 17:27   ` Ahmad Fatoum
2020-05-25 10:33 ` [PATCH 18/20] fastboot: rename usbgadget.fastboot_* variables to fastboot.* Sascha Hauer
2020-05-25 10:33 ` [PATCH 19/20] fastboot net: implement fastboot over UDP Sascha Hauer
2020-05-25 10:33 ` [PATCH 20/20] fastboot net: remove may_send Sascha Hauer
2020-05-25 19:45   ` Daniel Glöckner
2020-05-26  6:02     ` Sascha Hauer
2020-06-15 16:36       ` Daniel Glöckner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbfa7ccc-8a6d-5bed-c610-ce34d9611d33@emlix.com \
    --to=dg@emlix.com \
    --cc=barebox@lists.infradead.org \
    --cc=eh@emlix.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox