From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 2/2] reboot-mode: drop now unnecessary check
Date: Mon, 22 Mar 2021 12:50:36 +0100 [thread overview]
Message-ID: <bdd6b960-b421-f5b8-f1ea-15cbae1e5054@pengutronix.de> (raw)
In-Reply-To: <20210322112412.4232-2-s.hauer@pengutronix.de>
On 22.03.21 12:24, Sascha Hauer wrote:
> The reboot mode fixup tests if it is the live tree before modifying
> anything. This is unnecessary now as the live tree is never passed
> to fixups anymore.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/power/reset/reboot-mode.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/power/reset/reboot-mode.c b/drivers/power/reset/reboot-mode.c
> index df3be03edf..d9b51dfea6 100644
> --- a/drivers/power/reset/reboot-mode.c
> +++ b/drivers/power/reset/reboot-mode.c
> @@ -71,10 +71,6 @@ static int of_reboot_mode_fixup(struct device_node *root, void *ctx)
> srcnp = reboot->dev->device_node;
> dstnp = of_get_node_by_reproducible_name(root, srcnp);
>
> - /* nothing to do when called on barebox-internal tree */
> - if (srcnp == dstnp)
> - return 0;
> -
> if (dstnp) {
> dstparent = dstnp->parent;
> of_delete_node(dstnp);
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-03-22 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 11:24 [PATCH 1/2] of: Return copy of live tree as fixed tree Sascha Hauer
2021-03-22 11:24 ` [PATCH 2/2] reboot-mode: drop now unnecessary check Sascha Hauer
2021-03-22 11:50 ` Ahmad Fatoum [this message]
2021-03-22 11:48 ` [PATCH 1/2] of: Return copy of live tree as fixed tree Ahmad Fatoum
2021-03-22 12:31 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdd6b960-b421-f5b8-f1ea-15cbae1e5054@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox