Re: [PATCH 3/4] video: add MIPI DBI Type C Option 3 support

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 31.01.22 11:21, Sascha Hauer wrote:
> On Mon, Jan 31, 2022 at 09:03:01AM +0100, Ahmad Fatoum wrote:
>> Import the Linux v5.15 state of the driver to allow easy porting of
>> MIPI-DBI displays like the Ilitek 9431 added in a follow-up commit.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>>  commands/Kconfig             |  19 ++
>>  commands/Makefile            |   1 +
>>  commands/mipi_dbi.c          | 104 ++++++++
>>  drivers/video/Kconfig        |  14 ++
>>  drivers/video/Makefile       |   1 +
>>  drivers/video/mipi_dbi.c     | 467 +++++++++++++++++++++++++++++++++++
>>  include/spi/spi.h            |  20 ++
>>  include/video/mipi_dbi.h     | 105 ++++++++
>>  include/video/mipi_display.h | 150 +++++++++++
>>  9 files changed, 881 insertions(+)
>>  create mode 100644 commands/mipi_dbi.c
>>  create mode 100644 drivers/video/mipi_dbi.c
>>  create mode 100644 include/video/mipi_dbi.h
>>  create mode 100644 include/video/mipi_display.h
>>
>> diff --git a/commands/Kconfig b/commands/Kconfig
>> index ba8ca5cdebce..2e13a4ed90bd 100644
>> --- a/commands/Kconfig
>> +++ b/commands/Kconfig
>> @@ -1969,6 +1969,25 @@ config CMD_SPI
>>  		  -w BIT	bits per word (default 8)
>>  		  -v		verbose
>>  
>> +config CMD_MIPI_DBI
>> +	bool
>> +	depends on DRIVER_VIDEO_MIPI_DBI && SPI
>> +	select PRINTF_HEXSTR
>> +	prompt "mipi_dbi command"
>> +	help
>> +	  Write/read from MIPI DBI device on SPI bus
>> +
>> +	  Usage: mipi_dbi [-brcmfwv] DATA...
>> +
>> +	  Options:
>> +		  -b BUS	SPI bus number (default 0)
>> +		  -r COUNT	bytes to read
>> +		  -c		chip select (default 0)
>> +		  -m MODE	SPI mode (default 0)
>> +		  -f HZ		max speed frequency, in Hz (default 1 MHz)
>> +		  -w BIT	bits per word (default 8)
>> +		  -v		verbose
> 
> This doesn't match the actual command. Copy-paste from CMD_SPI above?
> 
>> +BAREBOX_CMD_HELP_START(mipi_dbi)
>> +BAREBOX_CMD_HELP_TEXT("Options:")
>> +BAREBOX_CMD_HELP_OPT ("-l\t",  "list all MIPI DBI devices")
>> +BAREBOX_CMD_HELP_OPT ("-d DEVICE",  "select specific device (default is first registered)")
>> +BAREBOX_CMD_HELP_OPT ("-w",  "issue write command")
>> +BAREBOX_CMD_HELP_END
>> +
>> +
>>  config DRIVER_VIDEO_BACKLIGHT
>>  	bool "Add backlight support"
>>  	help
>> @@ -178,4 +181,15 @@ config DRIVER_VIDEO_SIMPLE_PANEL
>>  	  Linux Kernel implementation this one is able to understand display-timings
>>  	  nodes so that it's not necessary to keep a list of all known displays
>>  	  with their corresponding timings in barebox.
>> +
>> +config DRIVER_VIDEO_PANEL_ILITEK_ILI9341
>> +	tristate "Ilitek ILI9341 240x320 QVGA panels"
>> +	depends on OFTREE && SPI
>> +	select DRIVER_VIDEO_MIPI_DBI
>> +	select VIDEO_VPL
>> +	help
>> +	  Say Y here if you want to enable support for Ilitek IL9341
>> +	  QVGA (240x320) RGB panels. support serial & parallel rgb
>> +	  interface.
> 
> This hunk should be in 4/4.

Ouch. Will fix both for v2.

Thanks,
Ahmad

> 
> Sascha
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox