Re: [PATCH 3/4] mci: sdhci: use the busy_timeout value in the sdhci_wait_idle functions

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 31.10.24 10:27, Sebastien Bourdelin wrote:
> From: Sebastien Bourdelin <sebastien.bourdelin@rtone.fr>
> 
> The busy_timeout value is used by the sdhci_wait_idle and
> sdhci_wait_idle_data functions to define the timeout to wait on when
> send a command to the controller.
> 
> The default value remains unchanged and is set to 10ms.
> 
> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@rtone.fr>

With below point addressed:

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> diff --git a/drivers/mci/sdhci.h b/drivers/mci/sdhci.h
> index 5de85239b1..757840acc7 100644
> --- a/drivers/mci/sdhci.h
> +++ b/drivers/mci/sdhci.h
> @@ -200,6 +200,8 @@
>  #define SDHCI_MAX_DIV_SPEC_200	256
>  #define SDHCI_MAX_DIV_SPEC_300	2046
>  
> +#define SDHCI_CMD_DEFAULT_BUSY_TIMEOUT 10

Please rename to SDHCI_CMD_DEFAULT_BUSY_TIMEOUT_MS

> +
>  struct sdhci {
>  	u32 (*read32)(struct sdhci *host, int reg);
>  	u16 (*read16)(struct sdhci *host, int reg);


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |