From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 29 Nov 2023 08:21:38 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r8Et7-00CyZD-1s for lore@lore.pengutronix.de; Wed, 29 Nov 2023 08:21:38 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8Et7-0001xx-KX for lore@pengutronix.de; Wed, 29 Nov 2023 08:21:38 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S1fGTfGAJ7oRlv+Fzw3eog8wLz7Yefqq7R3biscmCWM=; b=JMM4p5KG19YbbHfqB8msUw3e6Z 3RHfGhTNybOBP3SqVEQrbXadVHkSD9t9uKMvbkyRhldXzWqy92ieNCHVU18N7cjyXlZhpUchmEwbl fc5z3KS5kIH/o5Dy6HfEVhW37uaWDVSp36VAJ9EHcDY/pzlQ4iF9fRTETgcbhwMg87xACssco4+YY KO063EH1ap0LJRy2jL9vZ3yyAj8rToWhViKKulj4MhaMI71tHUXZ97Xy9JJSDHklOQ7IgSY7hpn2J yIv8FYYgq8ckN2lTyvqu1C73hAbMqMfulJL+orcU4iIOh2Kg7VhRQGmg/rU/KK/4MF9Qt1WASfGyC GP9e9SQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8Ere-007KBN-1v; Wed, 29 Nov 2023 07:20:06 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8Erb-007KAi-00 for barebox@lists.infradead.org; Wed, 29 Nov 2023 07:20:04 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1r8ErW-0001m0-Uw; Wed, 29 Nov 2023 08:19:59 +0100 Message-ID: Date: Wed, 29 Nov 2023 08:19:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Lior Weintraub , "barebox@lists.infradead.org" References: From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231128_232003_039196_03567993 X-CRM114-Status: GOOD ( 17.26 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: Pass user defines for Barebox build X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hello Lior, On 27.11.23 08:02, Lior Weintraub wrote: > Hi guys, > > Is there a formal way to pass user compilation flags into Barebox build? There isn't. Both barebox and Linux have been broken in the past by distros setting CFLAGS that force hardening options that require kernel/libc cooperation, which didn't apply to barebox. For that reason, the variables were prefixed with KBUILD_ and a way to inject variables into the build of barebox itself (i.e. not host tools) is intentionally not provided. What options do you want to inject? > I couldn't find one so I just patched the main Makefile > diff --git a/Makefile b/Makefile > index 471bbc2679..febc94b7f3 100644 > --- a/Makefile > +++ b/Makefile > @@ -443,7 +443,7 @@ KBUILD_CPPFLAGS := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builti > KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \ > -fno-strict-aliasing -fno-common -fshort-wchar \ > -Werror=implicit-function-declaration -Werror=implicit-int \ > - -Os -pipe -Wmissing-prototypes -std=gnu89 > + -Os -pipe -Wmissing-prototypes -std=gnu89 $(BAREBOX_USER_CFLAGS) USER is an unfortunate name, because there's already KBUILD_USERCFLAGS and that user is short for userspace and not the user, who is building barebox. Cheers, Ahmad > KBUILD_AFLAGS := -D__ASSEMBLY__ > KBUILD_AFLAGS_KERNEL := > KBUILD_CFLAGS_KERNEL := > > This patch allowed me to set BAREBOX_CFLAGS environment when calling make. > > Thanks,                          > Lior. > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |