From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mickerik.phytec.de ([195.145.39.210]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hkmIG-0001ca-2b for barebox@lists.infradead.org; Tue, 09 Jul 2019 09:20:14 +0000 References: <20190709085339.yvtusun63wqej5w5@pengutronix.de> From: =?UTF-8?Q?Stefan_Riedm=c3=bcller?= Message-ID: Date: Tue, 9 Jul 2019 11:20:10 +0200 MIME-Version: 1.0 In-Reply-To: <20190709085339.yvtusun63wqej5w5@pengutronix.de> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/8] ARM: dts: imx6qdl: phycore: Add state framework To: Roland Hieber Cc: Barebox Mailing List , Daniel Schultz Hi Roland, On 09.07.19 10:53, Roland Hieber wrote: > > Cc: barebox@lists.infradead.org > Bcc: > Subject: Re: [PATCH 2/8] ARM: dts: imx6qdl: phycore: Add state framework > Reply-To: > In-Reply-To: <1562071065-367410-2-git-send-email-s.riedmueller@phytec.de> > X-Sent-From: Pengutronix Hildesheim > X-URL: http://www.pengutronix.de/ > X-IRC: #ptxdist @freenode > X-Accept-Language: de,en > X-Accept-Content-Type: text/plain > X-Uptime: 10:41:58 up 1 day, 14:52, 50 users, load average: 0.08, 0.13, 0.10 > > Hi Stefan, Daniel, > > On Tue, Jul 02, 2019 at 02:37:39PM +0200, Stefan Riedmueller wrote: >> From: Daniel Schultz >> >> Add the state framework with EEPROM backend. >> >> Signed-off-by: Daniel Schultz >> Signed-off-by: Stefan Riedmueller >> --- >> arch/arm/dts/imx6dl-phytec-phycore-som-emmc.dts | 1 + >> arch/arm/dts/imx6dl-phytec-phycore-som-lc-emmc.dts | 1 + >> arch/arm/dts/imx6dl-phytec-phycore-som-lc-nand.dts | 1 + >> arch/arm/dts/imx6dl-phytec-phycore-som-nand.dts | 1 + >> arch/arm/dts/imx6q-phytec-phycore-som-emmc.dts | 1 + >> arch/arm/dts/imx6q-phytec-phycore-som-nand.dts | 1 + >> arch/arm/dts/imx6qdl-phytec-state.dtsi | 81 ++++++++++++++++++++++ >> 7 files changed, 87 insertions(+) >> create mode 100644 arch/arm/dts/imx6qdl-phytec-state.dtsi >> >> diff --git a/arch/arm/dts/imx6dl-phytec-phycore-som-emmc.dts b/arch/arm/dts/imx6dl-phytec-phycore-som-emmc.dts >> index a04e37f80363..21cbb5f944c9 100644 >> --- a/arch/arm/dts/imx6dl-phytec-phycore-som-emmc.dts >> +++ b/arch/arm/dts/imx6dl-phytec-phycore-som-emmc.dts >> @@ -15,6 +15,7 @@ >> #include >> #include "imx6dl.dtsi" >> #include "imx6qdl-phytec-phycore-som.dtsi" >> +#include "imx6qdl-phytec-state.dtsi" >> >> / { >> model = "Phytec phyCORE-i.MX6 DualLite/SOLO with eMMC"; >> diff --git a/arch/arm/dts/imx6dl-phytec-phycore-som-lc-emmc.dts b/arch/arm/dts/imx6dl-phytec-phycore-som-lc-emmc.dts >> index 5d9727ec5b80..b8efb95ee08a 100644 >> --- a/arch/arm/dts/imx6dl-phytec-phycore-som-lc-emmc.dts >> +++ b/arch/arm/dts/imx6dl-phytec-phycore-som-lc-emmc.dts >> @@ -9,6 +9,7 @@ >> #include >> #include "imx6dl.dtsi" >> #include "imx6qdl-phytec-phycore-som.dtsi" >> +#include "imx6qdl-phytec-state.dtsi" >> >> / { >> model = "PHYTEC phyCORE-i.MX6 DualLite/SOLO with eMMC low-cost"; >> diff --git a/arch/arm/dts/imx6dl-phytec-phycore-som-lc-nand.dts b/arch/arm/dts/imx6dl-phytec-phycore-som-lc-nand.dts >> index e119e4c0d4fc..4d38d1698a48 100644 >> --- a/arch/arm/dts/imx6dl-phytec-phycore-som-lc-nand.dts >> +++ b/arch/arm/dts/imx6dl-phytec-phycore-som-lc-nand.dts >> @@ -9,6 +9,7 @@ >> #include >> #include "imx6dl.dtsi" >> #include "imx6qdl-phytec-phycore-som.dtsi" >> +#include "imx6qdl-phytec-state.dtsi" >> >> / { >> model = "PHYTEC phyCORE-i.MX6 Duallite/SOLO with NAND low-cost"; >> diff --git a/arch/arm/dts/imx6dl-phytec-phycore-som-nand.dts b/arch/arm/dts/imx6dl-phytec-phycore-som-nand.dts >> index 287d876e41ed..3ad3723d2893 100644 >> --- a/arch/arm/dts/imx6dl-phytec-phycore-som-nand.dts >> +++ b/arch/arm/dts/imx6dl-phytec-phycore-som-nand.dts >> @@ -14,6 +14,7 @@ >> #include >> #include "imx6dl.dtsi" >> #include "imx6qdl-phytec-phycore-som.dtsi" >> +#include "imx6qdl-phytec-state.dtsi" >> >> / { >> model = "Phytec phyCORE-i.MX6 Duallite/SOLO with NAND"; >> diff --git a/arch/arm/dts/imx6q-phytec-phycore-som-emmc.dts b/arch/arm/dts/imx6q-phytec-phycore-som-emmc.dts >> index 94a70389f084..7a86d5b94daf 100644 >> --- a/arch/arm/dts/imx6q-phytec-phycore-som-emmc.dts >> +++ b/arch/arm/dts/imx6q-phytec-phycore-som-emmc.dts >> @@ -14,6 +14,7 @@ >> #include >> #include "imx6q.dtsi" >> #include "imx6qdl-phytec-phycore-som.dtsi" >> +#include "imx6qdl-phytec-state.dtsi" >> >> / { >> model = "Phytec phyCORE-i.MX6 Quad with eMMC"; >> diff --git a/arch/arm/dts/imx6q-phytec-phycore-som-nand.dts b/arch/arm/dts/imx6q-phytec-phycore-som-nand.dts >> index 6d82ec34d6e5..96d1de224c9e 100644 >> --- a/arch/arm/dts/imx6q-phytec-phycore-som-nand.dts >> +++ b/arch/arm/dts/imx6q-phytec-phycore-som-nand.dts >> @@ -14,6 +14,7 @@ >> #include >> #include "imx6q.dtsi" >> #include "imx6qdl-phytec-phycore-som.dtsi" >> +#include "imx6qdl-phytec-state.dtsi" >> >> / { >> model = "Phytec phyCORE-i.MX6 Quad with NAND"; >> diff --git a/arch/arm/dts/imx6qdl-phytec-state.dtsi b/arch/arm/dts/imx6qdl-phytec-state.dtsi >> new file mode 100644 >> index 000000000000..76aa15f3e2f7 >> --- /dev/null >> +++ b/arch/arm/dts/imx6qdl-phytec-state.dtsi >> @@ -0,0 +1,81 @@ >> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT) >> +/* >> + * Copyright (C) 2019 PHYTEC Messtechnik GmbH, >> + * Author: Daniel Schultz >> + */ >> + >> +/ { >> + aliases { >> + state = &state; >> + }; >> + >> + state: imx6qdl_phytec_boot_state { >> + magic = <0x883b86a6>; >> + compatible = "barebox,state"; >> + backend-type = "raw"; >> + backend = <&backend_update_eeprom>; >> + backend-stridesize = <54>; > > In order to be compatible with previous (and possibly future?) userspace > implementations, you should also set the backend-storage-type property. > We had cases in the past where userspace and barebox defaulted to > different storage types and could not understand each other. > > (For reference: https://www.barebox.org/doc/2019.06.0/user/state.html ) Thank you for the hint. I'll send a v2. Stefan > > - Roland > >> + >> + #address-cells = <1>; >> + #size-cells = <1>; >> + bootstate { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + last_chosen { >> + reg = <0x0 0x4>; >> + type = "uint32"; >> + }; >> + system0 { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + remaining_attempts { >> + reg = <0x4 0x4>; >> + type = "uint32"; >> + default = <3>; >> + }; >> + priority { >> + reg = <0x8 0x4>; >> + type = "uint32"; >> + default = <21>; >> + }; >> + ok { >> + reg = <0xc 0x4>; >> + type = "uint32"; >> + default = <0>; >> + }; >> + }; >> + system1 { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + remaining_attempts { >> + reg = <0x10 0x4>; >> + type = "uint32"; >> + default = <3>; >> + }; >> + priority { >> + reg = <0x14 0x4>; >> + type = "uint32"; >> + default = <20>; >> + }; >> + ok { >> + reg = <0x18 0x4>; >> + type = "uint32"; >> + default = <0>; >> + }; >> + }; >> + }; >> + }; >> +}; >> + >> +&eeprom { >> + status = "okay"; >> + partitions { >> + compatible = "fixed-partitions"; >> + #size-cells = <1>; >> + #address-cells = <1>; >> + backend_update_eeprom: state@0 { >> + reg = <0x0 0x100>; >> + label = "update-eeprom"; >> + }; >> + }; >> +}; >> -- >> 2.7.4 >> >> >> _______________________________________________ >> barebox mailing list >> barebox@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/barebox >> > _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox