From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH 02/18] ARM: boards: mx6-sabrelite: [cosmetic] make use of IMX_GPIO_NR
Date: Mon, 28 Sep 2020 18:00:45 +0200 [thread overview]
Message-ID: <c8b21a2a-70ba-81ec-7c3f-cec15868b6c2@pengutronix.de> (raw)
In-Reply-To: <20200928155041.32649-3-m.felsch@pengutronix.de>
On 9/28/20 5:50 PM, Marco Felsch wrote:
> Convert the global number to the more readable IMX_GPIO_NR() macro, no
> functional changes.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> .../boards/freescale-mx6-sabrelite/board.c | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boards/freescale-mx6-sabrelite/board.c b/arch/arm/boards/freescale-mx6-sabrelite/board.c
> index f4f2994a51..020a44297a 100644
> --- a/arch/arm/boards/freescale-mx6-sabrelite/board.c
> +++ b/arch/arm/boards/freescale-mx6-sabrelite/board.c
> @@ -70,37 +70,37 @@ static int ksz9021rn_phy_fixup(struct phy_device *dev)
>
> static struct gpio fec_gpios[] = {
> {
> - .gpio = 87,
> + .gpio = IMX_GPIO_NR(3, 23),
> .flags = GPIOF_OUT_INIT_LOW,
> .label = "phy-rst",
> }, {
> - .gpio = 190,
> + .gpio = IMX_GPIO_NR(6, 30),
> .flags = GPIOF_OUT_INIT_HIGH,
> .label = "phy-addr2",
> }, {
> - .gpio = 23,
> + .gpio = IMX_GPIO_NR(1, 23),
> .flags = GPIOF_OUT_INIT_LOW,
> .label = "phy-led-mode",
> }, {
> /* MODE strap-in pins: advertise all capabilities */
> - .gpio = 185,
> + .gpio = IMX_GPIO_NR(6, 25),
> .flags = GPIOF_OUT_INIT_HIGH,
> .label = "phy-adv1",
> }, {
> - .gpio = 187,
> + .gpio = IMX_GPIO_NR(6, 27),
> .flags = GPIOF_OUT_INIT_HIGH,
> .label = "phy-adv1",
> }, {
> - .gpio = 188,
> + .gpio = IMX_GPIO_NR(6, 28),
> .flags = GPIOF_OUT_INIT_HIGH,
> .label = "phy-adv1",
> }, {
> - .gpio = 189,
> + .gpio = IMX_GPIO_NR(6, 29),
> .flags = GPIOF_OUT_INIT_HIGH,
> .label = "phy-adv1",
> }, {
> /* Enable 125 MHz clock output */
> - .gpio = 184,
> + .gpio = IMX_GPIO_NR(6, 24),
> .flags = GPIOF_OUT_INIT_HIGH,
> .label = "phy-125MHz",
> },
> @@ -139,9 +139,9 @@ fs_initcall(sabrelite_ksz9021rn_setup);
> static void sabrelite_ehci_init(void)
> {
> /* hub reset */
> - gpio_direction_output(204, 0);
> + gpio_direction_output(IMX_GPIO_NR(7, 12), 0);
> udelay(2000);
> - gpio_set_value(204, 1);
> + gpio_set_value(IMX_GPIO_NR(7, 12), 1);
> }
>
> static int sabrelite_devices_init(void)
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-09-28 16:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 15:50 [PATCH 00/18] Barebox Deep-Probe Marco Felsch
2020-09-28 15:50 ` [PATCH 01/18] video: ssd1307fb: fix VBAT supply id Marco Felsch
2020-09-28 15:58 ` Ahmad Fatoum
2020-09-28 15:50 ` [PATCH 02/18] ARM: boards: mx6-sabrelite: [cosmetic] make use of IMX_GPIO_NR Marco Felsch
2020-09-28 16:00 ` Ahmad Fatoum [this message]
2020-09-28 15:50 ` [PATCH 03/18] drivers: gpio: treewide: [cosmetic] use register_driver_macros Marco Felsch
2020-09-28 16:04 ` Ahmad Fatoum
2020-09-29 8:20 ` Sascha Hauer
2020-09-28 15:50 ` [PATCH 04/18] ARM: mx6-sabrelite: remove obsolete sabrelite_mem_init() Marco Felsch
2020-09-28 16:07 ` Ahmad Fatoum
2020-09-28 15:50 ` [PATCH 05/18] spi: core: don't ignore register_device failures Marco Felsch
2020-09-28 15:50 ` [PATCH 06/18] regulator: improve of_regulator_register error handling Marco Felsch
2020-09-28 15:50 ` [PATCH 07/18] regulator: test of_regulator_register input before accessing it Marco Felsch
2020-09-28 16:11 ` Ahmad Fatoum
2020-09-28 15:50 ` [PATCH 08/18] regulator: stpmic1: fix registering missed regulators Marco Felsch
2020-09-28 15:50 ` [PATCH 09/18] regulator: add device reference to regulator_dev Marco Felsch
2020-09-28 15:50 ` [PATCH 10/18] regulator: treewide: drop local device_d reference Marco Felsch
2020-09-28 15:50 ` [PATCH 11/18] of: platform: fix of_amba_device_create stub return value Marco Felsch
2020-09-28 15:50 ` [PATCH 12/18] of: base: move memory init from DT to initcall Marco Felsch
2020-09-28 15:50 ` [PATCH 13/18] of: base: move clock init from of_probe() to barebox_register_of() Marco Felsch
2020-09-28 15:50 ` [PATCH 14/18] initcall: add of_populate_initcall Marco Felsch
2020-09-28 15:50 ` [PATCH 15/18] common: add initial barebox deep-probe support Marco Felsch
2020-09-28 16:53 ` Ahmad Fatoum
2020-09-29 15:55 ` Marco Felsch
2020-09-28 15:50 ` [PATCH 16/18] ARM: i.MX: esdctl: add " Marco Felsch
2020-09-28 15:50 ` [PATCH 17/18] ARM: stm32mp: ddrctrl: " Marco Felsch
2020-09-28 15:50 ` [PATCH 18/18] ARM: boards: mx6-sabrelite: " Marco Felsch
2020-09-28 16:58 ` Ahmad Fatoum
2020-09-29 8:30 ` [PATCH 00/18] Barebox Deep-Probe Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8b21a2a-70ba-81ec-7c3f-cec15868b6c2@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox