Re: [PATCH] usb: usb251xb: remove duplicate status line on probe success

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 23.05.22 10:22, Marco Felsch wrote:
> On 22-05-23, Ahmad Fatoum wrote:
>> Hello Marco,
>>
>> On 23.05.22 10:00, Marco Felsch wrote:
>>> Hi Ahmad,
>>>
>>> On 22-05-23, Ahmad Fatoum wrote:
>>>> A successful probe results in two lines logged:
>>>>
>>>>   usb251xb usb2514b0: Hub configuration was successful.
>>>
>>> The configuration (and this line) can be skipped if you specify
>>> "skip-config".
>>>
>>>>   usb251xb usb2514b0: Hub probed successfully
>>>>
>>>> There is no case where the first line is printed, but not the other and
>>>> they say about the same thing anyway, so drop the latter.
>>>
>>> The config step can fail. What about lower down the log level for the
>>> config step to dev_dbg() instead?
>>
>> If the config step fails we will get an error message from driver core.
>> A driver with skip-config doesn't do anything useful that warrants
>> a probed successfully message, so I think it's safe to drop it.
> 
> Hm.. with skip-config the driver still brings the hub out of reset and
> into a working state. Anyway just wanted to pointed out, that there are
> use-cases where the message is not printed twice.

Would you prefer I consolidate the logs messages into a single line instead?

> 
> Regards,
>   Marco
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox