[PATCH] usb: usb251xb: remove duplicate status line on probe success

[PATCH] usb: usb251xb: remove duplicate status line on probe success

[Ahmad Fatoum]

A successful probe results in two lines logged:

  usb251xb usb2514b0: Hub configuration was successful.
  usb251xb usb2514b0: Hub probed successfully

There is no case where the first line is printed, but not the other and
they say about the same thing anyway, so drop the latter.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/usb/misc/usb251xb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index 4871faf451ce..8d60f19e1355 100644
--- a/drivers/usb/misc/usb251xb.c
+++ b/drivers/usb/misc/usb251xb.c
@@ -639,8 +639,6 @@ static int usb251xb_probe(struct usb251xb *hub)
 		return err;
 	}
 
-	dev_info(dev, "Hub probed successfully\n");
-
 	return 0;
 }
 
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] usb: usb251xb: remove duplicate status line on probe success

[Marco Felsch]

Hi Ahmad,

On 22-05-23, Ahmad Fatoum wrote:
> A successful probe results in two lines logged:
> 
>   usb251xb usb2514b0: Hub configuration was successful.

The configuration (and this line) can be skipped if you specify
"skip-config".

>   usb251xb usb2514b0: Hub probed successfully
> 
> There is no case where the first line is printed, but not the other and
> they say about the same thing anyway, so drop the latter.

The config step can fail. What about lower down the log level for the
config step to dev_dbg() instead?

Regards,
  Marco


> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/usb/misc/usb251xb.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
> index 4871faf451ce..8d60f19e1355 100644
> --- a/drivers/usb/misc/usb251xb.c
> +++ b/drivers/usb/misc/usb251xb.c
> @@ -639,8 +639,6 @@ static int usb251xb_probe(struct usb251xb *hub)
>  		return err;
>  	}
>  
> -	dev_info(dev, "Hub probed successfully\n");
> -
>  	return 0;
>  }
>  
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] usb: usb251xb: remove duplicate status line on probe success

[Ahmad Fatoum]

Hello Marco,

On 23.05.22 10:00, Marco Felsch wrote:
> Hi Ahmad,
> 
> On 22-05-23, Ahmad Fatoum wrote:
>> A successful probe results in two lines logged:
>>
>>   usb251xb usb2514b0: Hub configuration was successful.
> 
> The configuration (and this line) can be skipped if you specify
> "skip-config".
> 
>>   usb251xb usb2514b0: Hub probed successfully
>>
>> There is no case where the first line is printed, but not the other and
>> they say about the same thing anyway, so drop the latter.
> 
> The config step can fail. What about lower down the log level for the
> config step to dev_dbg() instead?

If the config step fails we will get an error message from driver core.
A driver with skip-config doesn't do anything useful that warrants
a probed successfully message, so I think it's safe to drop it.

Cheers,
Ahmad

> 
> Regards,
>   Marco
> 
> 
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>>  drivers/usb/misc/usb251xb.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
>> index 4871faf451ce..8d60f19e1355 100644
>> --- a/drivers/usb/misc/usb251xb.c
>> +++ b/drivers/usb/misc/usb251xb.c
>> @@ -639,8 +639,6 @@ static int usb251xb_probe(struct usb251xb *hub)
>>  		return err;
>>  	}
>>  
>> -	dev_info(dev, "Hub probed successfully\n");
>> -
>>  	return 0;
>>  }
>>  
>> -- 
>> 2.30.2
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] usb: usb251xb: remove duplicate status line on probe success

[Marco Felsch]

On 22-05-23, Ahmad Fatoum wrote:
> Hello Marco,
> 
> On 23.05.22 10:00, Marco Felsch wrote:
> > Hi Ahmad,
> > 
> > On 22-05-23, Ahmad Fatoum wrote:
> >> A successful probe results in two lines logged:
> >>
> >>   usb251xb usb2514b0: Hub configuration was successful.
> > 
> > The configuration (and this line) can be skipped if you specify
> > "skip-config".
> > 
> >>   usb251xb usb2514b0: Hub probed successfully
> >>
> >> There is no case where the first line is printed, but not the other and
> >> they say about the same thing anyway, so drop the latter.
> > 
> > The config step can fail. What about lower down the log level for the
> > config step to dev_dbg() instead?
> 
> If the config step fails we will get an error message from driver core.
> A driver with skip-config doesn't do anything useful that warrants
> a probed successfully message, so I think it's safe to drop it.

Hm.. with skip-config the driver still brings the hub out of reset and
into a working state. Anyway just wanted to pointed out, that there are
use-cases where the message is not printed twice.

Regards,
  Marco

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] usb: usb251xb: remove duplicate status line on probe success

[Ahmad Fatoum]

On 23.05.22 10:22, Marco Felsch wrote:
> On 22-05-23, Ahmad Fatoum wrote:
>> Hello Marco,
>>
>> On 23.05.22 10:00, Marco Felsch wrote:
>>> Hi Ahmad,
>>>
>>> On 22-05-23, Ahmad Fatoum wrote:
>>>> A successful probe results in two lines logged:
>>>>
>>>>   usb251xb usb2514b0: Hub configuration was successful.
>>>
>>> The configuration (and this line) can be skipped if you specify
>>> "skip-config".
>>>
>>>>   usb251xb usb2514b0: Hub probed successfully
>>>>
>>>> There is no case where the first line is printed, but not the other and
>>>> they say about the same thing anyway, so drop the latter.
>>>
>>> The config step can fail. What about lower down the log level for the
>>> config step to dev_dbg() instead?
>>
>> If the config step fails we will get an error message from driver core.
>> A driver with skip-config doesn't do anything useful that warrants
>> a probed successfully message, so I think it's safe to drop it.
> 
> Hm.. with skip-config the driver still brings the hub out of reset and
> into a working state. Anyway just wanted to pointed out, that there are
> use-cases where the message is not printed twice.

Would you prefer I consolidate the logs messages into a single line instead?

> 
> Regards,
>   Marco
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] usb: usb251xb: remove duplicate status line on probe success

[Marco Felsch]

On 22-05-23, Ahmad Fatoum wrote:
> On 23.05.22 10:22, Marco Felsch wrote:
> > On 22-05-23, Ahmad Fatoum wrote:
> >> Hello Marco,
> >>
> >> On 23.05.22 10:00, Marco Felsch wrote:
> >>> Hi Ahmad,
> >>>
> >>> On 22-05-23, Ahmad Fatoum wrote:
> >>>> A successful probe results in two lines logged:
> >>>>
> >>>>   usb251xb usb2514b0: Hub configuration was successful.
> >>>
> >>> The configuration (and this line) can be skipped if you specify
> >>> "skip-config".
> >>>
> >>>>   usb251xb usb2514b0: Hub probed successfully
> >>>>
> >>>> There is no case where the first line is printed, but not the other and
> >>>> they say about the same thing anyway, so drop the latter.
> >>>
> >>> The config step can fail. What about lower down the log level for the
> >>> config step to dev_dbg() instead?
> >>
> >> If the config step fails we will get an error message from driver core.
> >> A driver with skip-config doesn't do anything useful that warrants
> >> a probed successfully message, so I think it's safe to drop it.
> > 
> > Hm.. with skip-config the driver still brings the hub out of reset and
> > into a working state. Anyway just wanted to pointed out, that there are
> > use-cases where the message is not printed twice.
> 
> Would you prefer I consolidate the logs messages into a single line instead?

Still think that the easiest would be to lower the hub configuration
print to dbg.  So one can enbale the debug on demand if needed. But a
single line info() seems fine for me as well.

Regards,
  Marco

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] usb: usb251xb: remove duplicate status line on probe success

[Sascha Hauer]

On Mon, May 23, 2022 at 12:11:06PM +0200, Marco Felsch wrote:
> On 22-05-23, Ahmad Fatoum wrote:
> > On 23.05.22 10:22, Marco Felsch wrote:
> > > On 22-05-23, Ahmad Fatoum wrote:
> > >> Hello Marco,
> > >>
> > >> On 23.05.22 10:00, Marco Felsch wrote:
> > >>> Hi Ahmad,
> > >>>
> > >>> On 22-05-23, Ahmad Fatoum wrote:
> > >>>> A successful probe results in two lines logged:
> > >>>>
> > >>>>   usb251xb usb2514b0: Hub configuration was successful.
> > >>>
> > >>> The configuration (and this line) can be skipped if you specify
> > >>> "skip-config".
> > >>>
> > >>>>   usb251xb usb2514b0: Hub probed successfully
> > >>>>
> > >>>> There is no case where the first line is printed, but not the other and
> > >>>> they say about the same thing anyway, so drop the latter.
> > >>>
> > >>> The config step can fail. What about lower down the log level for the
> > >>> config step to dev_dbg() instead?
> > >>
> > >> If the config step fails we will get an error message from driver core.
> > >> A driver with skip-config doesn't do anything useful that warrants
> > >> a probed successfully message, so I think it's safe to drop it.
> > > 
> > > Hm.. with skip-config the driver still brings the hub out of reset and
> > > into a working state. Anyway just wanted to pointed out, that there are
> > > use-cases where the message is not printed twice.
> > 
> > Would you prefer I consolidate the logs messages into a single line instead?
> 
> Still think that the easiest would be to lower the hub configuration
> print to dbg. 

+1

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox