mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: David Picard <david.picard@clermont.in2p3.fr>
To: barebox@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: setup_c: avoid clearing BSS twice
Date: Mon, 16 Mar 2026 14:21:37 +0100	[thread overview]
Message-ID: <ca6784d7-14c0-4716-8951-67d31fd40cdd@clermont.in2p3.fr> (raw)
In-Reply-To: <aa_1-MX7hnrlJ3Ff@pengutronix.de>

Hi,

I would like this patches be reverted, since, despite the proposed 
fixes, it prevents the board arch/arm/boards/enclustra-sa2 to boot.

With the option CONFIG_DEBUG_LL enabled, the output is:

lowlevel init done
SDRAM setup...
SDRAM calibration...
done

Then, it hangs.

David

Le 10/03/2026 à 11:44, Sascha Hauer a écrit :
> On Wed, Mar 04, 2026 at 10:05:38AM +0100, Ahmad Fatoum wrote:
>> Hi,
>>
>> On 3/4/26 8:53 AM, Sascha Hauer wrote:
>>> Add a bss_cleared variable that is set after the first call to
>>> setup_c(). On subsequent calls, the BSS clear is skipped to avoid
>>> wiping already-initialized data.
>>>
>>> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
>>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>>
>> Minor point below:
>>
>>> +.section .data
>> .data.bss_cleared or is it already in its own section?
> Fixed while applying.
>
> Sascha
>




  reply	other threads:[~2026-03-16 13:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  7:53 [PATCH v2 0/2] ARM: Avoid to clear bss multiple times Sascha Hauer
2026-03-04  7:53 ` [PATCH v2 1/2] ARM: setupc_32: remove relocation code from setup_c Sascha Hauer
2026-03-04  9:02   ` Ahmad Fatoum
2026-03-11 14:41   ` Ahmad Fatoum
2026-03-11 19:08     ` Sascha Hauer
2026-03-04  7:53 ` [PATCH v2 2/2] ARM: setup_c: avoid clearing BSS twice Sascha Hauer
2026-03-04  9:05   ` Ahmad Fatoum
2026-03-10 10:44     ` Sascha Hauer
2026-03-16 13:21       ` David Picard [this message]
2026-03-17  9:06         ` Sascha Hauer
2026-03-17  9:50           ` David Picard
2026-03-17 12:43           ` David Picard
2026-03-17 15:56             ` Ahmad Fatoum
2026-03-17 16:03               ` David Picard
2026-03-17 16:11                 ` Ahmad Fatoum
2026-03-18  7:49                   ` David Picard
2026-03-18  8:00                     ` Sascha Hauer
2026-03-18 10:06                       ` David Picard
2026-03-18 14:12                         ` David Picard
2026-03-18 14:55                           ` Sascha Hauer
2026-03-18 15:43                             ` David Picard
2026-03-23 13:22                             ` David Picard
2026-03-10 10:42 ` [PATCH v2 0/2] ARM: Avoid to clear bss multiple times Sascha Hauer
2026-03-17 10:21 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca6784d7-14c0-4716-8951-67d31fd40cdd@clermont.in2p3.fr \
    --to=david.picard@clermont.in2p3.fr \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox