From: Jonas Rebmann <jre@pengutronix.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH 0/2] Move pca9450 RESET_CTRL configuration to driver
Date: Tue, 11 Mar 2025 12:40:03 +0100 [thread overview]
Message-ID: <cbb86516-6337-44ba-a957-5620e5eb5015@pengutronix.de> (raw)
In-Reply-To: <a2b2fd98bb4d5f5597b55587ddc9f6b6e4da8fcb.camel@pengutronix.de>
Hi Rouven,
On 2025-03-11 12:05, Rouven Czerwinski wrote:
> Does it make sense to select the pcs9450 in the board kconfig symbols?
> This way users retain the behaviour after an update even if the pca9450
> driver was not selected before.
Are you referring to a scenario where removal of an explicit
initialization of PCA9450_RESET_CTRL in favor of the setup in the driver
would lead to an unitialized PCA9450_RESET_CTRL if the driver is not
enabled?
For the imx93 boards, behaviour remains unchanged same as those two
boards configure PCA9450_RESET_CTRL in pca9450_register_init_callback,
which is called by the driver. So change in behavior with those.
Not so on the imx8 boards where pmic_configure is called unconditionally
in the power-on routine.
Given this, I'm not sure if we should remove the explicit register
config for the imx8 boards as Ahmad mentioned. I think I remember Sasha
mentioning a reason why board kconfig doesn't select the pmic driver?..
- Jonas
next prev parent reply other threads:[~2025-03-11 11:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 10:50 Jonas Rebmann
2025-03-11 10:50 ` [PATCH 1/2] mfd: pca9450: configure pmic reset behavior Jonas Rebmann
2025-03-12 12:38 ` Sascha Hauer
2025-03-11 10:50 ` [PATCH 2/2] ARM: boards: remove obsolete PCA9450_RESET_CTRL setup Jonas Rebmann
2025-03-11 11:03 ` Ahmad Fatoum
2025-03-11 11:21 ` Jonas Rebmann
2025-03-11 11:42 ` Ahmad Fatoum
2025-03-12 12:43 ` Sascha Hauer
2025-03-11 11:05 ` [PATCH 0/2] Move pca9450 RESET_CTRL configuration to driver Rouven Czerwinski
2025-03-11 11:40 ` Jonas Rebmann [this message]
2025-03-11 11:42 ` Jonas Rebmann
2025-03-12 12:31 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbb86516-6337-44ba-a957-5620e5eb5015@pengutronix.de \
--to=jre@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=r.czerwinski@pengutronix.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox