Re: [PATCH v3 1/7] mci: sdhci: Set 8-bit host caps

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 18.08.23 16:22, Jules Maselbas wrote:
> Set the mci::host_cap MMC_CAP_8_BIT_DATA if supported by the hardware.
> 
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> ---
>  drivers/mci/sdhci.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mci/sdhci.c b/drivers/mci/sdhci.c
> index 635884e2a2..f6deea4020 100644
> --- a/drivers/mci/sdhci.c
> +++ b/drivers/mci/sdhci.c
> @@ -568,6 +568,9 @@ int sdhci_setup_host(struct sdhci *host)
>  	if (host->caps & SDHCI_CAN_DO_HISPD)
>  		mci->host_caps |= MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED;
>  
> +	if (host->caps & SDHCI_CAN_DO_8BIT)
> +		mci->host_caps |= MMC_CAP_8_BIT_DATA;

FYI, this is usually overridden by the bus-width DT property.
You (or Yann) will probably want to write it explicitly into the DT,
because bus width is not only a controller capability, but depends
on the eMMC and the board layout as well.

Cheers,
Ahmad

> +
>  	host->sdma_boundary = SDHCI_DMA_BOUNDARY_512K;
>  
>  	return 0;

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |