From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 17 Feb 2023 15:25:37 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pT1g9-00ABJJ-Km for lore@lore.pengutronix.de; Fri, 17 Feb 2023 15:25:37 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pT1g7-0006Cl-Nb for lore@pengutronix.de; Fri, 17 Feb 2023 15:25:37 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZIdplm23fxX+yWtvFJMXE3g/5cZQxYM22UjDt9Zpl48=; b=wt0coVaSn39DVNHn9uH4YjH/sj sC36RoPqXCwaPFHBz88YHB6zV8Pk70D+v1UlcpXgZvWiH9hVDTN1ReypF78UHGmqVtN4ztxbFz812 ceaWUWei6Eyo5qRr1m16VtR+o1V1R7u85ojWbGIlTHmqurHn8ABhhINVwSp9lt6ckt+qLDVBea7j9 1rA2tszVYVtwoG/Jyrryhip0lMwqng0ov7SBam54lOUJGiQGtIWD4EewG5BSUmStHgSQNjKQWjxuz GnPeTdPM/ZXsuQBB9+zViYvEqSVHdmyv+vxSQyNcvy+HXiDja+Tkq/KgHGjMosGXrL1boV534ejwf PLK+Qsgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pT1eg-00EX2U-KS; Fri, 17 Feb 2023 14:24:07 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pT1eO-00EX0m-5x for barebox@lists.infradead.org; Fri, 17 Feb 2023 14:23:49 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pT1eM-0005sQ-Ga; Fri, 17 Feb 2023 15:23:46 +0100 Message-ID: Date: Fri, 17 Feb 2023 15:23:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: Maxim Kochetkov , barebox@lists.infradead.org Cc: pmamonov@gmail.com, a.kuyan@yadro.com, p.mamonov@yadro.com, Maxim Kochetkov References: <20230217142006.60228-1-fido_max@inbox.ru> From: Ahmad Fatoum In-Reply-To: <20230217142006.60228-1-fido_max@inbox.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230217_062348_277166_0F6013AA X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v3 1/1] serial: ns16550: move iomem/ioport init after clock init X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 17.02.23 15:20, Maxim Kochetkov wrote: > While probing ns16550 clock provider may be unavailable and > clk_get() returns -EPROBE_DEFER. Next ns16550_probe() attempts > will be failed too because of dev_request_mem_resource() has already > acquired this resource for the device and returns -EBUSY. > So move resource allocation just after clock init. It will let proper > probe for defered clocks on boards with deep probe disabled. > > Signed-off-by: Maxim Kochetkov > Signed-off-by: Maxim Kochetkov Reviewed-by: Ahmad Fatoum Thanks! Ahmad > --- > drivers/serial/serial_ns16550.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c > index 16f3576645..9ce4feed43 100644 > --- a/drivers/serial/serial_ns16550.c > +++ b/drivers/serial/serial_ns16550.c > @@ -479,13 +479,6 @@ static int ns16550_probe(struct device *dev) > > priv = xzalloc(sizeof(*priv)); > > - ret = ns16550_init_iomem(dev, priv); > - if (ret) > - ret = ns16550_init_ioport(dev, priv); > - > - if (ret) > - return ret; > - > if (plat) > priv->plat = *plat; > else > @@ -511,6 +504,13 @@ static int ns16550_probe(struct device *dev) > goto err; > } > > + ret = ns16550_init_iomem(dev, priv); > + if (ret) > + ret = ns16550_init_ioport(dev, priv); > + > + if (ret) > + goto err; > + > cdev = &priv->cdev; > cdev->dev = dev; > cdev->tstc = ns16550_tstc; -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |