Re: [PATCH v1 4/4] ARM: boards: add support for Samsung Galaxy S20 5G (x1s)

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi Ivaylo,

On 7/29/25 22:36, Ivaylo Ivanov wrote:
> Add support for Samsung Galaxy S20 5G, based on exynos990, to the
> current samsung board support. This platform, just like exynos8895,
> needs a bit to be set in order to allow the framebuffer to refresh.
> 

Oh, a shame that I sold the old S20 FE I had. :/
I still have a rooted S10e though. I should give this a try when I have
time.

> diff --git a/arch/arm/dts/exynos990-x1s.dts b/arch/arm/dts/exynos990-x1s.dts
> new file mode 100644
> index 00000000..19d59eaa
> --- /dev/null
> +++ b/arch/arm/dts/exynos990-x1s.dts
> @@ -0,0 +1,13 @@
> +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> +/*
> + * Samsung Galaxy S20 5G (x1s/SM-G981B) barebox device tree source
> + *
> + * Copyright (c) 2025, Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> + */
> +
> +/dts-v1/;
> +#include <arm64/exynos/exynos990-x1s.dts>
> +
> +/ {
> +	barebox,disable-deep-probe;

Same comment: we want deep probe as default eventually. Did you run into
problems without this?

Cheers,
Ahmad

> +};

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |