From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>,
barebox@lists.infradead.org
Subject: Re: imx8: 'struct dram_timing_info' incompatibilities
Date: Mon, 29 Apr 2024 19:41:40 +0200 [thread overview]
Message-ID: <d360f4d9-dcfe-406a-8dbf-3fce88794f01@pengutronix.de> (raw)
In-Reply-To: <lyv840ku39.fsf@ensc-pc.intern.sigma-chemnitz.de>
Hello Enrico,
On 29.04.24 18:32, Enrico Scholz wrote:
> Hi,
>
> commit e6234f90 ("ddr: Initial i.MX9 support") adds unconditionally
> fields to the dram timing info object (include/soc/imx/ddr.h):
>
> | struct dram_timing_info {
> | ...
> | + /* fsp config */
> | + struct dram_fsp_cfg *fsp_cfg;
> | + unsigned int fsp_cfg_num;
>
>
> However, the iMX8 ATF ([1]) does not have this field and DRAM related
> SMC calls like
>
> | arm_smccc_smc(FSL_SIP_DDR_DVFS, 0x11, i, 0, 0, 0, 0, 0, &res);
>
> in the NXP busfreq-imx8mq.c driver will fail [2].
>
>
> Am I missing something here or should the dram_timing_info table somehow
> translated between these architectures (e.g. in dram_config_save())?
No, you are right. See the patch I shortly before:
https://lore.barebox.org/barebox/20240429141610.3556452-1-a.fatoum@pengutronix.de/T/#u
Cheers,
Ahmad
>
>
>
> Enrico
>
> Footnotes:
> [1] https://github.com/nxp-imx/imx-atf/blob/lf_v2.8/plat/imx/imx8m/include/dram.h
>
> [2] typical message: "imx_busfreq: probe of busfreq failed with error -22"
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2024-04-29 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 16:32 Enrico Scholz
2024-04-29 17:41 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d360f4d9-dcfe-406a-8dbf-3fce88794f01@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=enrico.scholz@sigma-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox