mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Michael Riesch <michael.riesch@wolfvision.net>,
	barebox@lists.infradead.org
Subject: Re: [PATCH v2 2/2] arm: rk3568-evb1: add support for Rockchip SARADC
Date: Wed, 23 Jun 2021 10:24:15 +0200	[thread overview]
Message-ID: <d65e99bc-b934-8dd2-0040-e9843a206099@pengutronix.de> (raw)
In-Reply-To: <20210623075201.5328-3-michael.riesch@wolfvision.net>



On 23.06.21 09:52, Michael Riesch wrote:
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> ---
> v2:
> - add initial version
> 
>  arch/arm/dts/rk3568-evb1-v10.dts |  5 +++++
>  arch/arm/dts/rk3568.dtsi         | 12 ++++++++++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/arch/arm/dts/rk3568-evb1-v10.dts b/arch/arm/dts/rk3568-evb1-v10.dts
> index ca6f9c280..b8b4c85bf 100644
> --- a/arch/arm/dts/rk3568-evb1-v10.dts
> +++ b/arch/arm/dts/rk3568-evb1-v10.dts
> @@ -485,3 +485,8 @@
>  &uart2 {
>  	status = "okay";
>  };
> +
> +&saradc {
> +	vref-supply = <&vcca_1v8>;
> +	status = "okay";
> +};
> diff --git a/arch/arm/dts/rk3568.dtsi b/arch/arm/dts/rk3568.dtsi
> index 34d0b8a08..8a75a7e96 100644
> --- a/arch/arm/dts/rk3568.dtsi
> +++ b/arch/arm/dts/rk3568.dtsi
> @@ -817,6 +817,18 @@
>  		status = "disabled";
>  	};
> 
> +	saradc: saradc@fe720000 {
> +		compatible = "rockchip,rk3568-saradc";
> +		reg = <0x0 0xfe720000 0x0 0x100>;
> +		interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cru CLK_SARADC>, <&cru PCLK_SARADC>;
> +		clock-names = "saradc", "apb_pclk";
> +		resets = <&cru SRST_P_SARADC>;
> +		reset-names = "saradc-apb";

Keep in mind the driver you added does _not_ trigger this reset.

> +		#io-channel-cells = <1>;
> +		status = "disabled";
> +	};
> +
>  	pinctrl: pinctrl {
>  		compatible = "rockchip,rk3568-pinctrl";
>  		rockchip,grf = <&grf>;
> --
> 2.20.1
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-06-23  8:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23  7:51 [PATCH v2 0/2] " Michael Riesch
2021-06-23  7:52 ` [PATCH v2 1/2] aiodev: add driver " Michael Riesch
2021-06-23  8:22   ` Ahmad Fatoum
2021-06-23  7:52 ` [PATCH v2 2/2] arm: rk3568-evb1: add support " Michael Riesch
2021-06-23  8:24   ` Ahmad Fatoum [this message]
2021-06-24 15:13     ` Michael Riesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d65e99bc-b934-8dd2-0040-e9843a206099@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=michael.riesch@wolfvision.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox