From: Lucas Stach <l.stach@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>,
Barebox List <barebox@lists.infradead.org>
Subject: Re: RK3568 some question
Date: Fri, 13 Oct 2023 12:53:07 +0200 [thread overview]
Message-ID: <d6f8e7f2487c9abc1086bbdb6533f9d439370e7f.camel@pengutronix.de> (raw)
In-Reply-To: <CAP1tNvRpgjbBKxCV94cOHdvFtgwmRz0fRX3B2=-FjYXCY+Z_MA@mail.gmail.com>
Am Freitag, dem 13.10.2023 um 11:12 +0300 schrieb Alexander Shiyan:
> Hello.
>
[...]
> I'm not too familiar with the PCI subsystem, but after briefly looking
> at the code,
> I saw in the setup_device() function the line:
> pci_write_config_dword(dev, pci_base_address_0, 0xfffffffe);
> On Linux and u-boot this value is ~0.
> The question is, are we doing the right thing here?
We can change this to be consistent with Linux, but in practice it
probably won't matter, as this bit signifies if the BAR is a memory or
IO resource and is hardcoded in any real device and not dependent on
writing ones to the BAR register to return the correct value.
Regards,
Lucas
prev parent reply other threads:[~2023-10-13 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 8:12 Alexander Shiyan
2023-10-13 10:37 ` Sascha Hauer
2023-10-13 10:53 ` Lucas Stach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6f8e7f2487c9abc1086bbdb6533f9d439370e7f.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox