mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Stefan Kerkmann <s.kerkmann@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH 0/2] downgrade noisy debug calls in block devices and ramfs
Date: Mon, 28 Oct 2024 17:44:07 +0100	[thread overview]
Message-ID: <d70eeeed-bb47-4d50-ac7e-5174c574aa33@pengutronix.de> (raw)
In-Reply-To: <20241028-fix-noisy-debug-calls-v1-0-e84ce4272313@pengutronix.de>

Hi,

On 28.10.24 17:17, Stefan Kerkmann wrote:
> These two patches are the outcome of an investigation why loading a
> fitimage from an eMMC took nearly 7s - the sheer amount of generated
> debugging messages slowed down the system by a factor of ~21 with
> KConfig options:
> 
> 	CONFIG_COMPILE_LOGLEVEL=7
> 	CONFIG_DEFAULT_LOGLEVEL=6
> 
> Which is the current default combination for barebox.
> 
> Before:
> 
> 	Booting entry 'system0'
> 	FIT: Reading time: 6722 ms
> 
> After:
> 
> 	Booting entry 'system0'
> 	FIT: Reading time: 324 ms

This is the time with these two patches applied or with
compile log level changed?

Cheers,
Ahmad

> 
> Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
> ---
> Stefan Kerkmann (2):
>       block: downgrade noisy debug calls to verbose debug
>       fs: ramfs: downgrade noisy debug calls to verbose debug
> 
>  common/block.c |  4 ++--
>  fs/ramfs.c     | 10 +++++-----
>  2 files changed, 7 insertions(+), 7 deletions(-)
> ---
> base-commit: 59658c877bcc605fe3ca36653b4f40f57856b81a
> change-id: 20241028-fix-noisy-debug-calls-a6d6185be705
> 
> Best regards,


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  parent reply	other threads:[~2024-10-28 16:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 16:17 Stefan Kerkmann
2024-10-28 16:17 ` [PATCH 1/2] block: downgrade noisy debug calls to verbose debug Stefan Kerkmann
2024-10-28 16:17 ` [PATCH 2/2] fs: ramfs: " Stefan Kerkmann
2024-10-28 16:44 ` Ahmad Fatoum [this message]
2024-10-28 16:57   ` [PATCH 0/2] downgrade noisy debug calls in block devices and ramfs Stefan Kerkmann
2024-10-29 13:33 ` Sascha Hauer
2024-10-29 13:55   ` Ahmad Fatoum
2024-10-29 14:12   ` Stefan Kerkmann
2024-10-30  8:50     ` Sascha Hauer
2024-10-30  8:47 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d70eeeed-bb47-4d50-ac7e-5174c574aa33@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s.kerkmann@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox