mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: chalianis1@gmail.com, s.hauer@pengutronix.de
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] arch: x86: efi_defconfig: remove framebuffer console to fix duplicate screen.
Date: Mon, 15 Sep 2025 11:00:32 +0200	[thread overview]
Message-ID: <d7d52aea-2785-4ed5-9f87-081350396d7a@pengutronix.de> (raw)
In-Reply-To: <20250914194027.32261-1-chalianis1@gmail.com>

Hi,

On 9/14/25 9:40 PM, chalianis1@gmail.com wrote:
> From: Chali Anis <chalianis1@gmail.com>
> 
> remove the framebuffer console and let develpers select it when needed, this
> fixes the problem that consist of having the screen splited to top and bottom
> displaying the output twice, and considerably speedup the efi payload on x86.
> 
> Fixes: 67498b411276 ("x86: configs: efi: enable some more useful options")
> Signed-off-by: Chali Anis <chalianis1@gmail.com>

In the worst case, the EFI stdio goes only to serial and users end up
seeing nothing on the screen at all with this configuration.

I thus don't think it's a good idea to disable it by default, unless we
have a way to check if stdio and GOP go to the same screen or not.

Cheers,
Ahmad

> ---
>  arch/x86/configs/efi_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/configs/efi_defconfig b/arch/x86/configs/efi_defconfig
> index 1dd823af40ea..9844a70d2628 100644
> --- a/arch/x86/configs/efi_defconfig
> +++ b/arch/x86/configs/efi_defconfig
> @@ -78,7 +78,6 @@ CONFIG_DRIVER_NET_EFI_SNP=y
>  CONFIG_DISK=y
>  CONFIG_DISK_WRITE=y
>  CONFIG_VIDEO=y
> -CONFIG_FRAMEBUFFER_CONSOLE=y
>  CONFIG_DRIVER_VIDEO_EFI_GOP=y
>  CONFIG_FINTEK_SUPERIO=y
>  CONFIG_SMSC_SUPERIO=y

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |




      reply	other threads:[~2025-09-15  9:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-14 19:40 chalianis1
2025-09-15  9:00 ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7d52aea-2785-4ed5-9f87-081350396d7a@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=chalianis1@gmail.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox