From: "Tomaž Šolc" <tomaz.solc@klevio.com>
To: barebox@lists.infradead.org
Subject: Re: Raspberry CM3 eMMC Boot
Date: Tue, 18 Jun 2019 14:17:01 +0200 [thread overview]
Message-ID: <d878a601-c20e-9513-7311-8deb713a8ba1@klevio.com> (raw)
In-Reply-To: <20190618075723.hnc5uabshtrypfda@pengutronix.de>
On 18. 06. 19 09:57, Sascha Hauer wrote:
> Hi Rico,
>
> On Mon, Jun 17, 2019 at 03:44:17PM +0200, Rico Pahlisch wrote:
>> -coredevice_initcall(bcm2835_gpio_add);
>> +device_initcall(bcm2835_gpio_add);
>
> I have no idea why this helps. Do you have any logs that explain the
> issue?
The problem is that gpio alt functions aren't getting setup correctly.
Rico's patch makes mci init take place before gpio init, which seems to
work around the problem, but doesn't actually fix the core issue.
The problem is actually my commit 9eed45c7, which was made before sdhost
driver was functional in barebox. It enables sdhci in devicetree, but
doesn't disable sdhost.
This makes both sdhost and sdhci nodes active. If
CONFIG_MCI_BCM283X_SDHOST is enabled (which is in rpi_defconfig since
b093468c), both drivers try to fetch the alt function for the same set
of GPIOs, which obviously doesn't work.
So basically what I think needs to be done is disable sdhci on Compute
Module now that sdhost works. Same thing as was done for R.Pi 3 by Lucas
in 9036d1db.
Rico, can you check if the patch below works for you?
Best regards
Tomaž
diff --git a/arch/arm/dts/bcm2837-rpi-cm3.dts
b/arch/arm/dts/bcm2837-rpi-cm3.dts
index cfbffe175..01c1f9a67 100644
--- a/arch/arm/dts/bcm2837-rpi-cm3.dts
+++ b/arch/arm/dts/bcm2837-rpi-cm3.dts
@@ -9,10 +9,3 @@
reg = <0x0 0x0>;
};
};
-
-&sdhci {
- pinctrl-0 = <&emmc_gpio48>;
- no-sd;
- non-removable;
- status = "okay";
-};
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-06-18 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 13:44 Rico Pahlisch
2019-06-18 7:57 ` Sascha Hauer
2019-06-18 8:51 ` Rico Pahlisch
2019-06-18 12:17 ` Tomaž Šolc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d878a601-c20e-9513-7311-8deb713a8ba1@klevio.com \
--to=tomaz.solc@klevio.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox