mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Fabian Pflug <fpg@pengutronix.de>
Subject: Re: [PATCH] common: optee: improve documentation of options
Date: Tue, 3 Jun 2025 13:00:07 +0200	[thread overview]
Message-ID: <e173690a-c1df-4103-b0ea-9294eb348220@pengutronix.de> (raw)
In-Reply-To: <20250603105914.3068724-1-a.fatoum@pengutronix.de>

Hi,

On 6/3/25 12:59, Ahmad Fatoum wrote:
> CONFIG_OPTEE_SIZE and CONFIG_OPTEE_SHM_SIZE have a correspondence to OP-TEE
> build config options, so point that out in the help text.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---

v1 -> v2:
  - fix confusion about CFG_SHMEM_SIZE erroneously not being part of
    CONFIG_OPTEE_SIZE

> Cc: Fabian Pflug <fpg@pengutronix.de>
> ---
>  common/Kconfig | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/common/Kconfig b/common/Kconfig
> index fe50da8f3084..987148847eac 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -1304,9 +1304,11 @@ config OPTEE_SIZE
>  	prompt "OP-TEE Memory Size"
>  	depends on HAVE_OPTEE
>  	help
> -	  Size to reserve in main memory for OP-TEE.
> +	  Size to reserve in main memory for OP-TEE, including its shared memory.
>  	  Can be larger than the actual size used by OP-TEE, this is used to prevent
>  	  barebox from using or speculating into this area.
> +	  On i.MX, this should be at least OP-TEE CFG_TZDRAM + CFG_SHMEM_SIZE.
> +	  The name of the CFG_ options may differ on other platforms.
>  
>  config OPTEE_SHM_SIZE
>  	hex
> @@ -1315,7 +1317,11 @@ config OPTEE_SHM_SIZE
>  	depends on HAVE_OPTEE
>  	help
>  	  Size to reserve in main memory for static OP-TEE shared memory
> -	  communication. Can be used for fixing up the OP-TEE OF node.
> +	  communication. The OP-TEE shared memory starts directly after
> +	  the OPTEE TZDRAM region. It should be chosen to be equivalent
> +	  to CFG_SHMEM_SIZE in OP-TEE.
> +
> +	  This value can be used for fixing up the OP-TEE OF node.
>  
>  	  A shared memory size of 0 means that only dynamic shared memory
>  	  will be supported for communication with OP-TEE. This is the only

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2025-06-03 11:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-03 10:59 Ahmad Fatoum
2025-06-03 11:00 ` Ahmad Fatoum [this message]
2025-06-05  6:55 ` Sascha Hauer
  -- strict thread matches above, loose matches on Subject: below --
2025-06-02 14:55 Ahmad Fatoum
2025-06-03  8:07 ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e173690a-c1df-4103-b0ea-9294eb348220@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=fpg@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox