From: Bastian Stender <bst@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] i2c: mv64xxx: fix indentation
Date: Mon, 22 May 2017 15:49:18 +0200 [thread overview]
Message-ID: <e2b029c9-0f11-5ec7-b780-e1965e41317a@pengutronix.de> (raw)
In-Reply-To: <20170522132934.9079-1-antonynpavlov@gmail.com>
On 05/22/2017 03:29 PM, Antony Pavlov wrote:
> The patch fixes this compiler's warning:
>
> drivers/i2c/busses/i2c-mv64xxx.c: In function ‘mv64xxx_i2c_fsm’:
> drivers/i2c/busses/i2c-mv64xxx.c:303:3: warning: this ‘if’ clause does
> not guard... [-Wmisleading-indentation]
> if (drv_data->bytes_left == 1)
> ^~
> drivers/i2c/busses/i2c-mv64xxx.c:305:4: note: ...this statement, but the
> latter is misleadingly indented as if it is guarded by the ‘if’
> udelay(2);
> ^~~~~~
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> Cc: Bastian Stender <bst@pengutronix.de>
> ---
> drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> index 1a5d5ef9b..285ede84c 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -302,7 +302,7 @@ mv64xxx_i2c_fsm(struct mv64xxx_i2c_data *drv_data, u32 status)
>
> if (drv_data->bytes_left == 1)
> drv_data->cntl_bits &= ~REG_CONTROL_ACK;
> - udelay(2);
> + udelay(2);
> break;
>
> case STATUS_MAST_RD_DATA_NO_ACK: /* 0x58 */
>
Yes, the indentation happened accidentally. I just checked the
functional spec again: the udelay is necessary regardless of
drv_data->bytes_left.
Thanks.
Regards,
Bastian
--
Pengutronix e.K.
Industrial Linux Solutions
http://www.pengutronix.de/
Peiner Str. 6-8, 31137 Hildesheim, Germany
Amtsgericht Hildesheim, HRA 2686
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-05-22 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 13:29 Antony Pavlov
2017-05-22 13:49 ` Bastian Stender [this message]
2017-05-23 8:02 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2b029c9-0f11-5ec7-b780-e1965e41317a@pengutronix.de \
--to=bst@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox