From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieJ9c-0007Un-Nf for barebox@lists.infradead.org; Mon, 09 Dec 2019 13:32:50 +0000 References: <20191204160200.4920-1-a.fatoum@pengutronix.de> <20191204160200.4920-2-a.fatoum@pengutronix.de> <20191209133110.y53btjurhhxyylpd@pengutronix.de> From: Ahmad Fatoum Message-ID: Date: Mon, 9 Dec 2019 14:32:46 +0100 MIME-Version: 1.0 In-Reply-To: <20191209133110.y53btjurhhxyylpd@pengutronix.de> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/3] ARM: i.MX: introduce imx_image_rule variable for code deduplication To: Sascha Hauer Cc: barebox@lists.infradead.org On 12/9/19 2:31 PM, Sascha Hauer wrote: > On Wed, Dec 04, 2019 at 05:01:59PM +0100, Ahmad Fatoum wrote: >> The next patch will add the .imxcfg file as a rule prerequisite, so the >> target is rebuilt if it changes. Instead of duplicating it in all rules, >> factor out the common parts into a imx_image_rule variable. >> >> No functional change. intended*. :-D > > Famous last words... > > This breaks imx_v8_defconfig build with: > > IMX-IMG images/start_nxp_imx8mq_evk.pblb.pimximg > image name not given Will check. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox