mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH master] optee: don't warn about missing OP-TEE header
Date: Thu, 29 Feb 2024 10:46:40 +0100	[thread overview]
Message-ID: <e930242d-0fa6-4387-82a2-112b519b619d@pengutronix.de> (raw)
In-Reply-To: <20240229093324.by6gutzs6g3bgknz@pengutronix.de>

On 29.02.24 10:33, Marco Felsch wrote:
> On 24-02-29, Ahmad Fatoum wrote:
>> hdr is a valid pointer for me, but it doesn't point at a header, which causes
>> me to get an error message.
> 
> Yes, I have noticed the code path for non-pbl part as well now :/
> 
> I was thinking about:
> 
> 	if (hdr->magic == 0)
> 		return -EINVAL;
> 
> but this is not far awways from you change. Therefore:

This would assume that DRAM is zero-initialized after POR, which isn't given.

> 
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> 
> PS: Could you please fix the silent check as well by using IS_ERR_OR_NULL()?

I will send a separate patch for that, so this can be picked up as-is.

Cheers,
Ahmad

> 
> Regards,
>   Marco
> 
>>
>> Thanks,
>> Ahmad
>>
>>>
>>> Regards,
>>>   Marco
>>>
>>>>  
>>>>  	if (hdr->magic != OPTEE_MAGIC) {
>>>> -		pr_err("Invalid header magic 0x%08x, expected 0x%08x\n",
>>>> -			   hdr->magic, OPTEE_MAGIC);
>>>> +		pr_debug("Invalid header magic 0x%08x, expected 0x%08x\n",
>>>> +			 hdr->magic, OPTEE_MAGIC);
>>>>  		return -EINVAL;
>>>>  	}
>>>>  
>>>> -- 
>>>> 2.39.2
>>>>
>>>>
>>>
>>
>> -- 
>> Pengutronix e.K.                           |                             |
>> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
>> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>>
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2024-02-29  9:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28 18:03 Ahmad Fatoum
2024-02-29  9:10 ` Marco Felsch
2024-02-29  9:17   ` Ahmad Fatoum
2024-02-29  9:33     ` Marco Felsch
2024-02-29  9:46       ` Ahmad Fatoum [this message]
2024-02-29 11:13         ` Marco Felsch
2024-02-29 11:46           ` Ahmad Fatoum
2024-03-01  9:21 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e930242d-0fa6-4387-82a2-112b519b619d@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox