From: "Middelschulte, Leif" <Leif.Middelschulte@klsmartin.com>
To: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: erroneous behavior for iMX+GPT
Date: Mon, 7 Oct 2019 14:15:39 +0000 [thread overview]
Message-ID: <ec68b5aec8f0a144e9391dd1dfabe129ecdd4b6a.camel@klsmartin.com> (raw)
Hi,
setting up GPT on an iMX6, I noticed a small bug subject to CONFIG_PARTITION_DISK_EFI_GPT_NO_FORCE that leads to unparsed GPTs.
Background: The iMX supports the mmc user partition as bootmedia source too.
Problem: The (additional) filetype check[0] fails, if the given buffer contains multiple, subsequent file(type)s. The buffer might contain the beginning of a disk that contains i.e. a Barebox image
*and* a partition table. The function file_detect_type returns a single (first recognized) type[1]. In my case, it returns the Barebox image type.
There is a comment about this additional check noting it will be mandatory as it will be "[..] added to the EFI Spec. per Intel after v1.02.". Anybody can elaborate on that?
That feedback could help to understand why file_detect_partition_table is insufficient in this case.
[0] https://git.pengutronix.de/cgit/barebox/tree/common/partitions/efi.c#n372
[1] https://git.pengutronix.de/cgit/barebox/tree/common/filetype.c#n352
--
Kind Regards,
Leif Middelschulte
Software Development Engineer
KLS Martin GmbH + Co. KG,
A Company of the KLS Martin Group
Am Flughafen 18
79108 Freiburg, Germany
Phone +49 (761) 557 997-543
Fax +49 (761) 557 997-520
Web leif.middelschulte@klsmartin.com
www.klsmartin.com
Commercial Register: Freiburg im Breisgau HRA 4044
Managing directors: Michael Martin, Karl Leibinger, Christian Leibinger
General partner: KLS Martin Verwaltungsgesellschaft mbH
Commercial register: Stuttgart HRB 451316
Tax ID number: DE 237467280
This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this
e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2019-10-07 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 14:15 Middelschulte, Leif [this message]
2019-10-14 12:25 ` Sascha Hauer
2019-10-14 12:30 ` Middelschulte, Leif
2019-10-14 12:45 ` s.hauer
2019-10-14 13:02 ` Middelschulte, Leif
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec68b5aec8f0a144e9391dd1dfabe129ecdd4b6a.camel@klsmartin.com \
--to=leif.middelschulte@klsmartin.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox