mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: barebox@lists.infradead.org
Subject: [PATCH net-pu] tftp: fix get
Date: Thu, 24 Jun 2010 16:26:16 +0300	[thread overview]
Message-ID: <ed04cb68b50f6426c0f154e489cf6436877e4b7a.1277385845.git.baruch@tkos.co.il> (raw)

With this patch tftp start requesting block 0 instead of 1. This fixes
tftp get on i.MX25 based board with tftpd-hpa server.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---

tftp push isn't working though. I get:

error frame: 0x83705178 0x00000882

from the fec driver. I'll investigate this if I have time.

 net/tftp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/tftp.c b/net/tftp.c
index c0d3278..14d9b5e 100644
--- a/net/tftp.c
+++ b/net/tftp.c
@@ -320,7 +320,7 @@ static int do_tftpb(struct command *cmdtp, int argc, char *argv[])
 
 	tftp_timer_start = get_time_ns();
 	tftp_state = tftp_put ? STATE_WRQ : STATE_RRQ;
-	tftp_block = 1;
+	tftp_block = 0;
 
 	tftp_err = tftp_send();
 	if (tftp_err)
-- 
1.7.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2010-06-24 13:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-24 13:26 Baruch Siach [this message]
2010-06-24 15:59 ` Sascha Hauer
2010-06-27  5:14   ` Baruch Siach
2010-06-28  7:55     ` Sascha Hauer
2010-06-28  8:22       ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed04cb68b50f6426c0f154e489cf6436877e4b7a.1277385845.git.baruch@tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox