Re: [PATCH] clk: clkdev: fix format security.

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi,

On 7/29/25 06:56, chalianis1@gmail.com wrote:
> From: Chali Anis <chalianis1@gmail.com>
> 
> not a string literal and no format
> arguments [-Werror=format-security]
> 
> Fixes: dfcdce8eec30 ("arm: add common clkdev")
> Signed-off-by: Chali Anis <chalianis1@gmail.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Thanks,
Ahmad

> ---
>  drivers/clk/clkdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index dbe998b6af35..1ce2eb95b8f9 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -273,7 +273,7 @@ int clk_add_alias(const char *alias, const char *alias_dev_name, char *id,
>  	if (IS_ERR(r))
>  		return PTR_ERR(r);
>  
> -	l = clkdev_alloc(r, alias, alias_dev_name);
> +	l = clkdev_alloc(r, alias, "%s", alias_dev_name);
>  	clk_put(r);
>  	if (!l)
>  		return -ENODEV;

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |