mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org, fpg@pengutronix.de
Subject: Re: [PATCH v2 04/10] globalvar: skip empty variables in globalvar_get_match()
Date: Thu, 15 Oct 2026 11:54:47 +0200	[thread overview]
Message-ID: <evt4nixcxhq6rcmdytq2rugefgnlvzhaaf3gwmv24dgj3xpgjg@ps7load5rnnx> (raw)
In-Reply-To: <20261015092308.146516-5-a.fatoum@pengutronix.de>

On 26-10-15 11:18, Ahmad Fatoum wrote:
> globalvar_get_match() concatenates all matching variables with the
> separator, whether they have a value or not. As variables like
> global.linux.bootargs.base or global.linux.bootargs.dyn.* are registered
> unconditionally, but often left empty, the resulting kernel command line
> would contain runs of multiple spaces.
> 
> Treat variables without a value as if they didn't exist at all.
> 
> Assisted-by: Claude:fable-5
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>



  reply	other threads:[~2026-10-15  9:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15  9:18 [PATCH v2 00/10] efi: payload: allow passing arguments to UKIs Ahmad Fatoum
2026-10-15  9:18 ` [PATCH v2 01/10] commands: devlookup: honour global.bootm.root_param for -k Ahmad Fatoum
2026-10-15  9:46   ` Marco Felsch
2026-10-15  9:52     ` Ahmad Fatoum
2026-10-15  9:18 ` [PATCH v2 02/10] common: bootargs: don't leave linux_bootargs dangling after free Ahmad Fatoum
2026-10-15  9:49   ` Marco Felsch
2026-10-15  9:18 ` [PATCH v2 03/10] common: bootargs: drop legacy bootargs fallback with FLEXIBLE_BOOTARGS Ahmad Fatoum
2026-10-15  9:52   ` Marco Felsch
2026-10-15  9:18 ` [PATCH v2 04/10] globalvar: skip empty variables in globalvar_get_match() Ahmad Fatoum
2026-10-15  9:54   ` Marco Felsch [this message]
2026-10-15  9:18 ` [PATCH v2 05/10] efi: payload: honour bootm dryrun in the EFI application handler Ahmad Fatoum
2026-10-15  9:18 ` [PATCH v2 06/10] efi: payload: always shutdown barebox when booting Ahmad Fatoum
2026-10-15 10:03   ` Marco Felsch
2026-10-15 10:16     ` Ahmad Fatoum
2026-10-15  9:18 ` [PATCH v2 07/10] efi: payload: pass shell arguments as load options to executed images Ahmad Fatoum
2026-10-15 10:14   ` Marco Felsch
2026-10-15 10:25     ` Ahmad Fatoum
2026-10-15 10:49       ` Marco Felsch
2026-10-15  9:18 ` [PATCH v2 08/10] efi: add global.efi.bootargs for bootm'd EFI applications Ahmad Fatoum
2026-10-15 10:34   ` Marco Felsch
2026-10-15 10:38     ` Ahmad Fatoum
2026-10-15  9:18 ` [PATCH v2 09/10] Documentation: efi: describe load options handling Ahmad Fatoum
2026-10-15 11:08   ` Marco Felsch
2026-10-15 11:19     ` Ahmad Fatoum
2026-10-15 12:13       ` Marco Felsch
2026-10-15 12:47         ` Ahmad Fatoum
2026-10-15  9:18 ` [PATCH v2 10/10] test: py: efiloader: check global.efi.bootargs reaches the kernel Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=evt4nixcxhq6rcmdytq2rugefgnlvzhaaf3gwmv24dgj3xpgjg@ps7load5rnnx \
    --to=m.felsch@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=fpg@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox