From: "Schenk, Gavin" <G.Schenk@eckelmann.de>
To: "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH v2] usb: gadget: allow to actually enable sparse fastboot support
Date: Tue, 7 Aug 2018 14:59:42 +0000 [thread overview]
Message-ID: <f298d0f75f080bc09b029427b6831c29e586a367.camel@eckelmann.de> (raw)
In-Reply-To: <20180807142344.26219-1-u.kleine-koenig@pengutronix.de>
Hi,
On Tue, 2018-08-07 at 16:23 +0200, Uwe Kleine-König wrote:
> When sparse support was (intended to be) made optional it was
> effectively unconditionally disabled because
>
> IS_ENABLED(USB_GADGET_FASTBOOT_SPARSE)
>
> always evaluates to 0. To actually make use of the introduced kconfig
> symbol the CONFIG_ prefix must not be skipped.
>
> Fixes: f4b5d3eeb607 ("usb: gadget: fastboot: Make sparse support optional")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>
Tested-by: Gavin Schenk <g.schenk@eckelmann.de>
Finally, and with this patch, fastboot works in sparse mode on a i.MX25 based machine with 128MB RAM.
My Test:
* cp /dev/zero /dev/mmc0.0
* usbgadget -A /dev/mmc0.0(system0)
* sudo fastboot flash system0 platform-eag-ci4000/images/root.ext2 (on host)
* boot /mnt/mmc0.0
* \o/
Thanks!
Regards
Gavin Schenk
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-08-07 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 14:17 [PATCH] " Uwe Kleine-König
2018-08-07 14:23 ` [PATCH v2] " Uwe Kleine-König
2018-08-07 14:59 ` Schenk, Gavin [this message]
2018-08-08 7:32 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f298d0f75f080bc09b029427b6831c29e586a367.camel@eckelmann.de \
--to=g.schenk@eckelmann.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox