From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] ARM: OMAP: xload: Fix compile without CONFIG_MTD
Date: Thu, 2 Jun 2022 11:01:00 +0200 [thread overview]
Message-ID: <f4ef4f26-d4b8-85f5-e438-d51e0d9a109c@pengutronix.de> (raw)
In-Reply-To: <CAP1tNvTeo5S3k4CPm3dFw7-TxJUFaS-82Cu=R+DN1VWwQY+iCg@mail.gmail.com>
On 02.06.22 10:59, Alexander Shiyan wrote:
> Hello.
>
> It's just the result of the my master branch not being updated
> from remote before I made the changes... Sorry :)
>
> чт, 2 июн. 2022 г. в 11:07, Ahmad Fatoum <a.fatoum@pengutronix.de>:
>> On 01.06.22 09:14, Alexander Shiyan wrote:
>>> arm-linux-ld: arch/arm/mach-omap/xload.o: in function read_mtd_barebox':
>>> /home/ARM/barebox/arch/arm/mach-omap/xload.c:75: undefined reference to mtd_peb_read_file'
>>
>> Am I missing something or does this patch just change
>>
>> if (0) {
Typo: if (1)
>> return NULL;
>> }
>>
>> /* something */;
>> return to;
>>
>> into
>>
>> if (0) {
>> /* something */
>> return to;
>> }
>> return NULL;
>>
>>
>> This shouldn't really make a difference. How old is your GCC?
i.e. this patch can be dropped again?
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-06-02 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 7:14 Alexander Shiyan
2022-06-02 6:55 ` Sascha Hauer
2022-06-02 8:07 ` Ahmad Fatoum
2022-06-02 8:59 ` Alexander Shiyan
2022-06-02 9:01 ` Ahmad Fatoum [this message]
2022-06-02 9:10 ` Alexander Shiyan
2022-06-03 6:56 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4ef4f26-d4b8-85f5-e438-d51e0d9a109c@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox