mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] scripts: get_maintainers: drop --status enforcement
Date: Thu, 26 Oct 2023 16:29:36 +0200	[thread overview]
Message-ID: <f6245eb6-d2be-ab06-eccf-74714559efbd@pengutronix.de> (raw)
In-Reply-To: <20231026142708.wyz6vsgkb3lasyhz@pengutronix.de>

On 26.10.23 16:27, Marco Felsch wrote:
> On 23-10-26, Ahmad Fatoum wrote:
>> On 26.10.23 14:46, Marco Felsch wrote:
>>> The status parameter is never used so drop it and stop bother the user
>>> of the script.
>>>
>>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>>
>> Our get_maintainer.pl script doesn't have the same breadth of features
>> as the kernel's and only --status is implemented, thus the check.
> 
> Where? I see only 'print << 'EOT' <text> EOT'

Ye, the output is similar to what you'd get with the kernel's --status.
The script is just here, because checkpatch depends on it and calls
it with --status.

Cheers,
Ahmad

> 
> Regards,
>   Marco
> 
>>
>>> ---
>>>  scripts/get_maintainer.pl | 2 --
>>>  1 file changed, 2 deletions(-)
>>>
>>> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
>>> index 7c0d50333400..a19c0e7305d0 100755
>>> --- a/scripts/get_maintainer.pl
>>> +++ b/scripts/get_maintainer.pl
>>> @@ -2,8 +2,6 @@
>>>  # SPDX-License-Identifier: GPL-2.0-only
>>>  # Dummy get_maintainer.pl script for checkpatch.pl to use
>>>  
>>> -die "USAGE: get_maintainer.pl --status\n" unless grep /--status/, @ARGV;
>>> -
>>>  print <<'EOT'
>>>  Sascha Hauer <s.hauer@pengutronix.de> (maintainer:BAREBOX)
>>>  barebox@lists.infradead.org (open list:BAREBOX)
>>
>> -- 
>> Pengutronix e.K.                           |                             |
>> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
>> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>>
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2023-10-26 14:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-26 12:46 [PATCH 1/2] usb: gadget: initialize serialnumber as empty string Marco Felsch
2023-10-26 12:46 ` [PATCH 2/2] scripts: get_maintainers: drop --status enforcement Marco Felsch
2023-10-26 14:21   ` Ahmad Fatoum
2023-10-26 14:27     ` Marco Felsch
2023-10-26 14:29       ` Ahmad Fatoum [this message]
2023-10-26 14:34         ` Marco Felsch
2023-10-26 21:30           ` Ahmad Fatoum
2023-10-26 14:18 ` [PATCH 1/2] usb: gadget: initialize serialnumber as empty string Ahmad Fatoum
2023-10-26 14:31   ` Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6245eb6-d2be-ab06-eccf-74714559efbd@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox