mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Oleksij Rempel <linux@rempel-privat.de>
To: barebox@lists.infradead.org
Subject: Re: [RFC PATCH 1/2] usb: gadget: start usbgadget automatically
Date: Fri, 24 Mar 2017 11:19:46 +0100	[thread overview]
Message-ID: <f9037857-f0b7-355e-439f-bc7bad3dfdfb@rempel-privat.de> (raw)
In-Reply-To: <20170324090725.22192-1-o.rempel@pengutronix.de>


[-- Attachment #1.1.1: Type: text/plain, Size: 3965 bytes --]

After personal feedback i'll resend the patches without RFC

Am 24.03.2017 um 10:07 schrieb Oleksij Rempel:
> ... if glocal variable configured to do this.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  drivers/usb/gadget/Kconfig     |  6 ++++
>  drivers/usb/gadget/Makefile    |  1 +
>  drivers/usb/gadget/autostart.c | 67 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 74 insertions(+)
>  create mode 100644 drivers/usb/gadget/autostart.c
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index eb279ae8d..dd5d4a75a 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -30,6 +30,12 @@ config USB_GADGET_DRIVER_PXA27X
>  	default y
>  	select USB_GADGET_DUALSPEED
>  
> +config USB_GADGET_AUTOSTART
> +	bool
> +	default y
> +	select ENVIRONMENT_VARIABLES
> +	prompt "Automatically start usbgadget on boot"
> +
>  comment "USB Gadget drivers"
>  
>  config USB_GADGET_DFU
> diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
> index 9ef594575..e74cf0266 100644
> --- a/drivers/usb/gadget/Makefile
> +++ b/drivers/usb/gadget/Makefile
> @@ -1,5 +1,6 @@
>  
>  obj-$(CONFIG_USB_GADGET) += composite.o config.o usbstring.o epautoconf.o udc-core.o functions.o config.o multi.o
> +obj-$(CONFIG_USB_GADGET_AUTOSTART) += autostart.o
>  obj-$(CONFIG_USB_GADGET_SERIAL) += u_serial.o serial.o f_serial.o f_acm.o
>  obj-$(CONFIG_USB_GADGET_DFU) += dfu.o
>  obj-$(CONFIG_USB_GADGET_FASTBOOT) += f_fastboot.o
> diff --git a/drivers/usb/gadget/autostart.c b/drivers/usb/gadget/autostart.c
> new file mode 100644
> index 000000000..43c2ba23d
> --- /dev/null
> +++ b/drivers/usb/gadget/autostart.c
> @@ -0,0 +1,67 @@
> +/*
> + * Copyright (c) 2017 Oleksij Rempel <o.rempel@pengutronix.de>, Pengutronix
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2
> + * as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + */
> +#include <common.h>
> +#include <command.h>
> +#include <errno.h>
> +#include <malloc.h>
> +#include <getopt.h>
> +#include <fs.h>
> +#include <xfuncs.h>
> +#include <usb/usbserial.h>
> +#include <usb/dfu.h>
> +#include <usb/gadget-multi.h>
> +#include <globalvar.h>
> +#include <magicvar.h>
> +
> +static int autostart;
> +static int acm;
> +static char *fastboot_function;
> +
> +static int usbgadget_autostart(void)
> +{
> +	struct f_multi_opts opts = {};
> +
> +	if (!autostart)
> +		return 0;
> +
> +	if (fastboot_function)
> +		opts.fastboot_opts.files = file_list_parse(fastboot_function);
> +
> +	opts.create_acm = acm;
> +
> +	return usb_multi_register(&opts);
> +}
> +postenvironment_initcall(usbgadget_autostart);
> +
> +static int usbgadget_globalvars_init(void)
> +{
> +
> +	globalvar_add_simple_bool("usbgadget.autostart", &autostart);
> +	globalvar_add_simple_bool("usbgadget.acm", &acm);
> +	globalvar_add_simple_string("usbgadget.fastboot_function",
> +				    &fastboot_function);
> +
> +	return 0;
> +}
> +device_initcall(usbgadget_globalvars_init);
> +
> +BAREBOX_MAGICVAR_NAMED(global_usbgadget_autostart,
> +		       global.usbgadget.autostart,
> +		       "usbgadget: Automatically start usbgadget on boot");
> +BAREBOX_MAGICVAR_NAMED(global_usbgadget_acm,
> +		       global.usbgadget.acm,
> +		       "usbgadget: Create CDC ACM function");
> +BAREBOX_MAGICVAR_NAMED(global_usbgadget_fastboot_function,
> +		       global.usbgadget.fastboot_function,
> +		       "usbgadget: Create Android Fastboot function");
> 


-- 
Regards,
Oleksij


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2017-03-24 10:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24  9:07 Oleksij Rempel
2017-03-24  9:07 ` [RFC PATCH 2/2] commands: usbgadget: provide fall back to global variables Oleksij Rempel
2017-03-24 10:19 ` Oleksij Rempel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9037857-f0b7-355e-439f-bc7bad3dfdfb@rempel-privat.de \
    --to=linux@rempel-privat.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox