mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Daniel Krüger" <daniel.krueger@systec-electronic.com>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 6/6] fs: squashfs: Do not default on xz
Date: Fri, 21 Oct 2016 10:23:55 +0200	[thread overview]
Message-ID: <fa561303-8330-208b-3588-bf9f4807d8cd@systec-electronic.com> (raw)
In-Reply-To: <20161021065124.7328-6-s.hauer@pengutronix.de>

Hi Sascha,

I tried this patch series, because I need Squashfs zlib support.

I get the following output during configuration/build:
 >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
scripts/kconfig/conf --silentoldconfig Kconfig
lib/lzo/Kconfig:1:error: recursive dependency detected!
lib/lzo/Kconfig:1:	symbol LZO_DECOMPRESS is selected by SQUASHFS_LZO
fs/squashfs/Kconfig:49:	symbol SQUASHFS_LZO depends on LZO_DECOMPRESS
lib/Kconfig:21:error: recursive dependency detected!
lib/Kconfig:21:	symbol XZ_DECOMPRESS is selected by SQUASHFS_XZ
fs/squashfs/Kconfig:63:	symbol SQUASHFS_XZ depends on XZ_DECOMPRESS
lib/Kconfig:9:error: recursive dependency detected!
lib/Kconfig:9:	symbol ZLIB is selected by SQUASHFS_ZLIB
fs/squashfs/Kconfig:24:	symbol SQUASHFS_ZLIB depends on ZLIB
lib/Kconfig:17:error: recursive dependency detected!
lib/Kconfig:17:	symbol LZ4_DECOMPRESS is selected by SQUASHFS_LZ4
fs/squashfs/Kconfig:35:	symbol SQUASHFS_LZ4 depends on LZ4_DECOMPRESS
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

cu,
   Daniel

Am 21.10.2016 um 08:51 schrieb Sascha Hauer:
> The default compression algorithm for squashfs is zlib, so only
> do a 'default y' there. For xz change to 'default y if the algorithm
> is enabled anyway' likke the other compression algorithms do.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  fs/squashfs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/squashfs/Kconfig b/fs/squashfs/Kconfig
> index 2e28e90..b84ef75 100644
> --- a/fs/squashfs/Kconfig
> +++ b/fs/squashfs/Kconfig
> @@ -60,7 +60,7 @@ config SQUASHFS_LZO
>
>  config SQUASHFS_XZ
>  	bool "Include support for XZ compressed file systems"
> -	default y
> +	default y if XZ_DECOMPRESS
>  	depends on FS_SQUASHFS
>  	select XZ_DECOMPRESS
>  	help
>

-- 

SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund

Telefon : +49 (0) 3765 38600-0
Fax     : +49 (0) 3765 38600-4100
Email   : daniel.krueger@systec-electronic.com
Website : http://www.systec-electronic.com

Managing Directors  :
   Dipl.-Phys. Siegmar Schmidt, Dipl. Ing. (FH) Armin von Collrepp
Commercial registry : Amtsgericht Chemnitz, HRB 28082
USt.-Id Nr.         : DE150534010


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-10-21  8:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  6:51 [PATCH 1/6] fs: squashfs: port lzo compression support from kernel Sascha Hauer
2016-10-21  6:51 ` [PATCH 2/6] fs: squashfs: port lz4 " Sascha Hauer
2016-10-21  6:51 ` [PATCH 3/6] fs: squashfs: port zlib " Sascha Hauer
2016-10-21  6:51 ` [PATCH 4/6] Add filetype and detection for squashfs images Sascha Hauer
2016-10-21  6:51 ` [PATCH 5/6] fs: squashfs: append linux rootarg for ubi volume Sascha Hauer
2016-10-21  6:51 ` [PATCH 6/6] fs: squashfs: Do not default on xz Sascha Hauer
2016-10-21  8:23   ` Daniel Krüger [this message]
2016-10-21  9:48     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa561303-8330-208b-3588-bf9f4807d8cd@systec-electronic.com \
    --to=daniel.krueger@systec-electronic.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox