From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>, Juergen Borleis <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] HABv4: remove useless error message
Date: Mon, 2 Dec 2019 14:24:54 +0100 [thread overview]
Message-ID: <fa5ac462-27f0-d9c5-e771-1c6775616f05@pengutronix.de> (raw)
In-Reply-To: <20191202130736.xgs53nadr5uvokea@pengutronix.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 1382 bytes --]
On 12/2/19 2:07 PM, Roland Hieber wrote:
> On Mon, Dec 02, 2019 at 11:24:48AM +0100, Juergen Borleis wrote:
>> This change removes the stupid error message at the end of the generated
>
> I think there was some reason behind that code, so it is probably not
> stupid, and you've run into an edge case that never happened before (at
> least I've never seen this on any of my boards when using HABv4).
The last time, I've seen this messages was before implementing:
81e2b508e785 i.MX habv4: habv4_get_status(): display warning events, too
So Roland is probably right, you've hit a corner case, that's not
correctly handled.
> The code goes back until the first incarnaction of HABv4 in commit
> 29abc10d44c2 - Marc, do you still know more details why it was done this
> way?
This was part of the patches I picked up from fsl, see commit message
for more details:
29abc10d44c2 habv4: add High Assurance Boot v4
Albeit giving an incorrect error message, it showed that there were
warnings events on the new mx6 silicon revisions that were not handled
before 81e2b508e785.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-12-02 13:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 10:24 Juergen Borleis
2019-12-02 10:24 ` [PATCH 2/2] HABv4: fix ROM code API usage Juergen Borleis
2019-12-02 13:07 ` [PATCH 1/2] HABv4: remove useless error message Roland Hieber
2019-12-02 13:24 ` Marc Kleine-Budde [this message]
2019-12-02 13:33 ` Roland Hieber
2019-12-02 13:38 ` Marc Kleine-Budde
2019-12-02 14:30 ` Juergen Borleis
2019-12-03 14:04 ` Marc Kleine-Budde
2019-12-03 14:36 ` Sascha Hauer
2019-12-03 14:47 ` Marc Kleine-Budde
2019-12-03 14:51 ` Juergen Borleis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa5ac462-27f0-d9c5-e771-1c6775616f05@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox