From: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] OMAP: disable unaligned access when building the IFT
Date: Wed, 05 Dec 2012 12:43:17 +0100 [thread overview]
Message-ID: <ly4nk03esq.fsf@ensc-virt.intern.sigma-chemnitz.de> (raw)
In-Reply-To: <ly8v9c3f95.fsf@ensc-virt.intern.sigma-chemnitz.de> (Enrico Scholz's message of "Wed, 05 Dec 2012 12:33:26 +0100")
Enrico Scholz <enrico.scholz@sigma-chemnitz.de> writes:
>>> commit b823fd9ba56d56e3cbb5b05e7a4815fb0914204a
>>> Author: Albert ARIBAUD <albert.u.boot@aribaud.net>
>>> Date: Tue Oct 9 09:28:15 2012 +0000
>>> ARM: prevent misaligned array inits
>> ...
>> This patch explicitely mentions char arrays initialized on the stack
>> like this:
>
> I do not know the backgrounds of this patch but without additional
> context, I think it is wrong.
ah... found it:
| be actually unnecessary. In order to catch these accesses and remove
| or optimize them, option -munaligned-access is explicitly set for all
| versions of gcc which support it.
e.g. u-boot sets '-munaligned-access' unconditionally which is imo
silly. And now, they are trying to fix this mess by compiling single
files with '-mno-unaligned-access'...
Enrico
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-12-05 11:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 12:02 [PATCH 1/2] ARM: added Kconfig option for -mno-unaligned compiler flag Enrico Scholz
2012-12-04 12:02 ` [PATCH 2/2] OMAP: disable unaligned access when building the IFT Enrico Scholz
2012-12-05 10:46 ` Sascha Hauer
2012-12-05 11:33 ` Enrico Scholz
2012-12-05 11:43 ` Enrico Scholz [this message]
2012-12-05 12:15 ` Sascha Hauer
2012-12-05 13:25 ` Enrico Scholz
2012-12-05 14:43 ` Enrico Scholz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ly4nk03esq.fsf@ensc-virt.intern.sigma-chemnitz.de \
--to=enrico.scholz@sigma-chemnitz.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox