From: Krzysztof Halasa <khc@pm.waw.pl>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: put a valid "barebox" signature in the header on big-endian systems.
Date: Sun, 13 May 2012 12:05:33 +0200 [thread overview]
Message-ID: <m3k40gflaq.fsf@intrepid.localdomain> (raw)
In-Reply-To: <20120512213845.GA22395@pengutronix.de> ("Uwe =?utf-8?Q?Klein?= =?utf-8?Q?e-K=C3=B6nig=22's?= message of "Sat, 12 May 2012 23:38:45 +0200")
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
>> +++ b/arch/arm/include/asm/barebox-arm-head.h
>> @@ -24,8 +24,7 @@ static inline void barebox_arm_head(void)
>> "1: b 1b\n"
>> "1: b 1b\n"
>> #endif
>> - ".word 0x65726162\n" /* 'bare' */
>> - ".word 0x00786f62\n" /* 'box' */
>> + ".asciz \"barebox\"\n"
>> ".word _text\n" /* text base. If copied there,
>> * barebox can skip relocation
>> */
> Another downside of this patch (apart from the file type detection that
> still needs adaption?) is that the magic is different depending on
> endianess.
Actually it's the opposite - i.e., the magic is now always "barebox\0"
and doesn't depend on endianness :-)
Without this patch, the magic changes with endianness (it becomes
"erab\0xob" on BE).
> Just my 0.02€ on this patch, I don't know how many big endian barebox
> images are out there
Guess I have most of these here :-)
Jean-Christophe may have some, too.
--
Krzysztof Halasa
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-05-13 10:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-05 21:47 Krzysztof Halasa
2012-05-06 18:17 ` Sascha Hauer
2012-05-06 20:19 ` Krzysztof Halasa
2012-05-10 12:30 ` Sascha Hauer
2012-05-12 21:38 ` Uwe Kleine-König
2012-05-12 23:56 ` Antony Pavlov
2012-05-13 0:17 ` Uwe Kleine-König
2012-05-13 10:05 ` Krzysztof Halasa [this message]
2012-05-13 12:20 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k40gflaq.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox