[PATCH] NOR flash: reduce size of cfiword_t if not using 64-bit bus.

[PATCH] NOR flash: reduce size of cfiword_t if not using 64-bit bus.

[Krzysztof Halasa]

Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>

diff --git a/drivers/nor/cfi_flash.h b/drivers/nor/cfi_flash.h
index df482b6..fec0894 100644
--- a/drivers/nor/cfi_flash.h
+++ b/drivers/nor/cfi_flash.h
@@ -30,7 +30,17 @@
 #include <linux/mtd/mtd.h>
 
 typedef unsigned long flash_sect_t;
+
+#if   defined(CONFIG_DRIVER_CFI_BANK_WIDTH_8)
 typedef u64 cfiword_t;
+#elif defined(CONFIG_DRIVER_CFI_BANK_WIDTH_4)
+typedef u32 cfiword_t;
+#elif defined(CONFIG_DRIVER_CFI_BANK_WIDTH_2)
+typedef u16 cfiword_t;
+#else
+typedef u8 cfiword_t;
+#endif
+
 struct cfi_cmd_set;
 
 /*-----------------------------------------------------------------------

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] NOR flash: reduce size of cfiword_t if not using 64-bit bus.

[Sascha Hauer]

Hi Krzysztof,

On Sat, May 05, 2012 at 11:35:10PM +0200, Krzysztof Halasa wrote:
> Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
> 
> diff --git a/drivers/nor/cfi_flash.h b/drivers/nor/cfi_flash.h
> index df482b6..fec0894 100644
> --- a/drivers/nor/cfi_flash.h
> +++ b/drivers/nor/cfi_flash.h
> @@ -30,7 +30,17 @@
>  #include <linux/mtd/mtd.h>
>  
>  typedef unsigned long flash_sect_t;
> +
> +#if   defined(CONFIG_DRIVER_CFI_BANK_WIDTH_8)
>  typedef u64 cfiword_t;
> +#elif defined(CONFIG_DRIVER_CFI_BANK_WIDTH_4)
> +typedef u32 cfiword_t;
> +#elif defined(CONFIG_DRIVER_CFI_BANK_WIDTH_2)
> +typedef u16 cfiword_t;
> +#else
> +typedef u8 cfiword_t;
> +#endif

Is this worth it? Do we safe binary size or what else is the reasoning
for this patch?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] NOR flash: reduce size of cfiword_t if not using 64-bit bus.

[Krzysztof Halasa]

Hi,

Sascha Hauer <s.hauer@pengutronix.de> writes:

>> +++ b/drivers/nor/cfi_flash.h
>> @@ -30,7 +30,17 @@
>>  #include <linux/mtd/mtd.h>
>>  
>>  typedef unsigned long flash_sect_t;
>> +
>> +#if   defined(CONFIG_DRIVER_CFI_BANK_WIDTH_8)
>>  typedef u64 cfiword_t;
>> +#elif defined(CONFIG_DRIVER_CFI_BANK_WIDTH_4)
>> +typedef u32 cfiword_t;
>> +#elif defined(CONFIG_DRIVER_CFI_BANK_WIDTH_2)
>> +typedef u16 cfiword_t;
>> +#else
>> +typedef u8 cfiword_t;
>> +#endif
>
> Is this worth it? Do we safe binary size or what else is the reasoning
> for this patch?

Well, I haven't done any measurments :-(
But I guess long long operations on a 32-bit CPU aren't very effective.

Just checked, with WIDTH_2 on my IXP425 the barebox.bin shrunk from
239456 to 239264 bytes. That's 192 bytes saved with this patch.
-- 
Krzysztof Halasa

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] NOR flash: reduce size of cfiword_t if not using 64-bit bus.

[Sascha Hauer]

On Sat, May 05, 2012 at 11:35:10PM +0200, Krzysztof Halasa wrote:
> Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>

Applied, thanks

Sascha

> 
> diff --git a/drivers/nor/cfi_flash.h b/drivers/nor/cfi_flash.h
> index df482b6..fec0894 100644
> --- a/drivers/nor/cfi_flash.h
> +++ b/drivers/nor/cfi_flash.h
> @@ -30,7 +30,17 @@
>  #include <linux/mtd/mtd.h>
>  
>  typedef unsigned long flash_sect_t;
> +
> +#if   defined(CONFIG_DRIVER_CFI_BANK_WIDTH_8)
>  typedef u64 cfiword_t;
> +#elif defined(CONFIG_DRIVER_CFI_BANK_WIDTH_4)
> +typedef u32 cfiword_t;
> +#elif defined(CONFIG_DRIVER_CFI_BANK_WIDTH_2)
> +typedef u16 cfiword_t;
> +#else
> +typedef u8 cfiword_t;
> +#endif
> +
>  struct cfi_cmd_set;
>  
>  /*-----------------------------------------------------------------------
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox