Re: [PATCH master] partition: fix reference to wrong cdev in warning message

["Uwe Kleine-König" <uwe@kleine-koenig.org>]

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

Hello Ahmad,

On Tue, Mar 18, 2025 at 12:23:19PM +0100, Ahmad Fatoum wrote:
> On 3/18/25 12:16, Uwe Kleine-König wrote:
> > This improves the error messages on my ts433 from
> > 
> > 	WARNING: mmc0: Failed to create link from mmc0.primary to mmc0
> > 	WARNING: mmc0: Failed to create link from mmc0.primary to mmc0
> > 	WARNING: mmc0: Failed to create link from mmc0.primary to mmc0
> > 	WARNING: mmc0: Failed to create link from mmc0.primary to mmc0
> > 	WARNING: mmc0: Failed to create link from mmc0.primary to mmc0
> > 
> > to 
> > 
> > 	WARNING: mmc0: Failed to create link from mmc0.primary to mmc0.2
> > 	WARNING: mmc0: Failed to create link from mmc0.primary to mmc0.3
> > 	WARNING: mmc0: Failed to create link from mmc0.primary to mmc0.4
> > 	WARNING: mmc0: Failed to create link from mmc0.primary to mmc0.5
> > 	WARNING: mmc0: Failed to create link from mmc0.primary to mmc0.6
> > 
> > I still don't understand why barebox intends to create mmc0.primary for
> > all these partitions, but still it's an obviously right improvement.
> 
> Thanks for testing. I still suspect that you have multiple on-disk
> partitions with the same label. What does lsblk -o name,label,partlabel
> say?

indeed:

	# lsblk -o name,label,partlabel /dev/mmcblk0
	NAME        LABEL          PARTLABEL
	mmcblk0
	├─mmcblk0p1                uboot
	├─mmcblk0p2 QTS_BOOT_PART2 primary
	├─mmcblk0p3 QTS_BOOT_PART3 primary
	├─mmcblk0p4                primary
	├─mmcblk0p5                primary
	├─mmcblk0p6                primary
	└─mmcblk0p7                primary

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]