Re: [DistroKit] [PATCH 2/7] firmware-imx: move to the correct section

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 02.06.23 16:59, Michael Olbrich wrote:
> There is a non_free_firmware  section, which is exactly for packages
> like this.
> 
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  configs/platform-v8a/platformconfig        | 8 ++++----
>  configs/platform-v8a/rules/firmware-imx.in | 3 +--
>  2 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/configs/platform-v8a/platformconfig b/configs/platform-v8a/platformconfig
> index 4e479660f6b7..7ac44a8777bd 100644
> --- a/configs/platform-v8a/platformconfig
> +++ b/configs/platform-v8a/platformconfig
> @@ -301,6 +301,10 @@ PTXCONF_HOST_M4=y
>  PTXCONF_HOST_OPENSSL=y
>  PTXCONF_HOST_SYSTEM_BC=y
>  PTXCONF_HOST_UTIL_LINUX=y
> +
> +#
> +# non-free firmware blobs       
> +#
>  PTXCONF_FIRMWARE_IMX=y
>  # PTXCONF_FIRMWARE_IMX_VPU_IMX27 is not set
>  # PTXCONF_FIRMWARE_IMX_VPU_IMX51 is not set
> @@ -308,10 +312,6 @@ PTXCONF_FIRMWARE_IMX=y
>  # PTXCONF_FIRMWARE_IMX_VPU_IMX6DL is not set
>  # PTXCONF_FIRMWARE_IMX_VPU_IMX6Q is not set
>  PTXCONF_FIRMWARE_IMX_BOOTIMAGE_IMX8=y
> -
> -#
> -# non-free firmware blobs       
> -#
>  PTXCONF_FIRMWARE_ROCKCHIP=y
>  # PTXCONF_FIRMWARE_ROCKCHIP_RK3566_SDRAM is not set
>  PTXCONF_FIRMWARE_ROCKCHIP_RK3568_SDRAM=y
> diff --git a/configs/platform-v8a/rules/firmware-imx.in b/configs/platform-v8a/rules/firmware-imx.in
> index c756b963e5dc..8c76b693d257 100644
> --- a/configs/platform-v8a/rules/firmware-imx.in
> +++ b/configs/platform-v8a/rules/firmware-imx.in
> @@ -1,5 +1,4 @@
> -## SECTION=hosttools_platform
> -# This should be in a firmware section, once we added that.
> +## SECTION=non_free_firmware
>  
>  menuconfig FIRMWARE_IMX
>  	tristate

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |