From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 11 Jan 2024 19:06:30 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rNzRm-00DGs4-0b for lore@lore.pengutronix.de; Thu, 11 Jan 2024 19:06:30 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rNzRl-0008MT-Ll; Thu, 11 Jan 2024 19:06:29 +0100 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rNzRj-0008L7-J7; Thu, 11 Jan 2024 19:06:27 +0100 Message-ID: <0a782c11-f93e-4a7b-bd64-92e96bf023b0@pengutronix.de> Date: Thu, 11 Jan 2024 19:06:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: =?UTF-8?Q?Jan_L=C3=BCbbe?= , =?UTF-8?Q?Leonard_G=C3=B6hrs?= , distrokit@pengutronix.de References: <20240111150117.3678555-1-l.goehrs@pengutronix.de> <20240111150117.3678555-3-l.goehrs@pengutronix.de> From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [DistroKit] [PATCH v1 2/5] v8a: images: imx8m: add barebox state partition X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Tretter Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On 11.01.24 18:07, Jan Lübbe wrote: > On Thu, 2024-01-11 at 16:01 +0100, Leonard Göhrs wrote: >> Having a place to store state allows us to use RAUC on i.MX8M based boards. >> >> Signed-off-by: Leonard Göhrs >> --- >> configs/platform-v8a/config/images/imx8m.config | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/configs/platform-v8a/config/images/imx8m.config b/configs/platform-v8a/config/images/imx8m.config >> index 59cdac1..fcb3c07 100644 >> --- a/configs/platform-v8a/config/images/imx8m.config >> +++ b/configs/platform-v8a/config/images/imx8m.config >> @@ -9,8 +9,13 @@ image @IMAGE@ { >> in-partition-table = false >> holes = {"(440; 32K)"} If you are changing the partitioning, please increase the barebox partition size too. As we are adding more boards to the same binary, this area will get more crowded and we are already nearly at the limit. >> } >> - partition root-A { >> + partition barebox-state { >> offset = 2M >> + size = 1M > > There's no need to use 1MB for the state partition, a few sectors should be > enough (i.e. 32KB). > >> + partition-type-uuid = 4778ed65-bf42-45fa-9c5b-287a1dc4aab1 # barebox-state >> + image = /dev/null >> + } >> + partition root-A { > > Keep the root-A partition @ 2M and add a small state partition before the > rootfs. > >> image = "root.ext2" >> partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae >> } > > Similar to the rock3a.config, we should have a barebox env partition as well. @Michael, as we are touching partitioning, should we increase the partition size in the same go? What size would you suggest? Cheers, Ahmad > > Jan -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |