From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 06 Nov 2023 10:41:56 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qzw7I-0005I2-Eo for lore@lore.pengutronix.de; Mon, 06 Nov 2023 10:41:56 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qzw7H-0006uY-Or; Mon, 06 Nov 2023 10:41:55 +0100 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qzw7F-0006tN-Pq; Mon, 06 Nov 2023 10:41:53 +0100 Message-ID: <0e511ae7-c367-11c4-d458-d9f381d5f789@pengutronix.de> Date: Mon, 6 Nov 2023 10:41:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Roland Hieber References: <20231103182438.1051601-1-rhi@pengutronix.de> <20231103182438.1051601-3-rhi@pengutronix.de> <20231106094030.6ej4xwxbh2neelsv@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20231106094030.6ej4xwxbh2neelsv@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH 03/10] treewide: images: remove size specifications for root partitions X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On 06.11.23 10:40, Roland Hieber wrote: > On Mon, Nov 06, 2023 at 09:21:20AM +0100, Ahmad Fatoum wrote: >> Hello Roland, >> >> On 03.11.23 19:24, Roland Hieber wrote: >>> With current rootfs sizes of below 200 MiB there is no need to have a >>> 512 MiB root partition, which will be a lot larger than the file system >>> it contains, and which will also all have to be written to the SD card. >>> Let genimage determine the partition size based on the file system image >>> it contains, thereby reducing the size of the generated disk images. >> >> Does that mean that there will be no free space on the partition whatsoever? >> It's beneficial for testing to either have some spare space to remount the >> rootfs r/w and place some drop-in configuration files or an overlay that >> achieves the same. > > No. That setting is controlled by PTXCONF_IMAGE_ROOT_EXT_SIZE, which is > still at 125%, so the resulting root.ext2 is 25% larger than necessary. Thanks for the clarification. In that case: Reviewed-by: Ahmad Fatoum > > - Roland > >> >> Cheers, >> Ahmad >> >>> >>> Signed-off-by: Roland Hieber >>> --- >>> configs/platform-mips/config/images/ar9331.config | 1 - >>> configs/platform-mips/config/images/malta.config | 1 - >>> configs/platform-mipsel/config/images/malta.config | 1 - >>> configs/platform-v7a/config/images/vexpress.config | 1 - >>> configs/platform-v7a_noneon/config/images/vexpress.config | 1 - >>> configs/platform-v8a/config/images/espressobin.config | 1 - >>> 6 files changed, 6 deletions(-) >>> >>> diff --git a/configs/platform-mips/config/images/ar9331.config b/configs/platform-mips/config/images/ar9331.config >>> index f26627f84cc0..7685781d231a 100644 >>> --- a/configs/platform-mips/config/images/ar9331.config >>> +++ b/configs/platform-mips/config/images/ar9331.config >>> @@ -9,7 +9,6 @@ image @IMAGE@ { >>> partition root-A { >>> image = root.ext2 >>> partition-type-uuid = e9434544-6e2c-47cc-bae2-12d6deafb44c # root-mips >>> - size = 512M >>> } >>> partition data { >>> autoresize = true >>> diff --git a/configs/platform-mips/config/images/malta.config b/configs/platform-mips/config/images/malta.config >>> index f26627f84cc0..7685781d231a 100644 >>> --- a/configs/platform-mips/config/images/malta.config >>> +++ b/configs/platform-mips/config/images/malta.config >>> @@ -9,7 +9,6 @@ image @IMAGE@ { >>> partition root-A { >>> image = root.ext2 >>> partition-type-uuid = e9434544-6e2c-47cc-bae2-12d6deafb44c # root-mips >>> - size = 512M >>> } >>> partition data { >>> autoresize = true >>> diff --git a/configs/platform-mipsel/config/images/malta.config b/configs/platform-mipsel/config/images/malta.config >>> index c873c7e8b724..71e367276072 100644 >>> --- a/configs/platform-mipsel/config/images/malta.config >>> +++ b/configs/platform-mipsel/config/images/malta.config >>> @@ -9,7 +9,6 @@ image @IMAGE@ { >>> partition root-A { >>> image = root.ext2 >>> partition-type-uuid = 37c58c8a-d913-4156-a25f-48b1b64e07f0 # root-mips-le >>> - size = 512M >>> } >>> partition data { >>> autoresize = true >>> diff --git a/configs/platform-v7a/config/images/vexpress.config b/configs/platform-v7a/config/images/vexpress.config >>> index 87eaedfe8b82..67c7638a59b8 100644 >>> --- a/configs/platform-v7a/config/images/vexpress.config >>> +++ b/configs/platform-v7a/config/images/vexpress.config >>> @@ -9,7 +9,6 @@ image @IMAGE@ { >>> partition root-A { >>> image = root.ext2 >>> partition-type-uuid = 69dad710-2ce4-4e3c-b16c-21a1d49abed3 # root-arm >>> - size = 96M >>> } >>> partition root-B { >>> image = root.ext2 >>> diff --git a/configs/platform-v7a_noneon/config/images/vexpress.config b/configs/platform-v7a_noneon/config/images/vexpress.config >>> index 0712ad82ce96..4200f95b7725 100644 >>> --- a/configs/platform-v7a_noneon/config/images/vexpress.config >>> +++ b/configs/platform-v7a_noneon/config/images/vexpress.config >>> @@ -9,7 +9,6 @@ image @IMAGE@ { >>> partition root-A { >>> image = root.ext2 >>> partition-type-uuid = 69dad710-2ce4-4e3c-b16c-21a1d49abed3 # root-arm >>> - size = 192M >>> } >>> partition data { >>> autoresize = true >>> diff --git a/configs/platform-v8a/config/images/espressobin.config b/configs/platform-v8a/config/images/espressobin.config >>> index 188bb9ae4d9e..e9f4460c9a9a 100644 >>> --- a/configs/platform-v8a/config/images/espressobin.config >>> +++ b/configs/platform-v8a/config/images/espressobin.config >>> @@ -6,7 +6,6 @@ image @IMAGE@ { >>> partition root-A { >>> image = root.ext2 >>> partition-type-uuid = 69dad710-2ce4-4e3c-b16c-21a1d49abed3 # root-arm >>> - size = 512M >>> } >>> partition data { >>> size = 512M >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >> >> >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |