DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Michael Olbrich <m.olbrich@pengutronix.de>, distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH] blspec-rpi4: move rule file to platform-v7a/rules/
Date: Mon, 12 Dec 2022 18:06:59 +0100	[thread overview]
Message-ID: <19b5fa1c-cb99-8cc8-268e-71bb1f7d894f@pengutronix.de> (raw)
In-Reply-To: <20221212082318.3291073-1-m.olbrich@pengutronix.de>

Hello Michael,

On 12.12.22 09:23, Michael Olbrich wrote:
> The menu file and all other blspec packages are defined in the platform as
> well. Without this "ptxdist lint" reports for all other platforms:

I placed it top-level, because I intended for the rule to be reused
when 64-bit support for the Raspberry Pi 4b is added to DistroKit.

Is there a way to accommodate this without ptxdist lint complaining?

Cheers,
Ahmad

> 
> [...]
> Checking kconfig symbols in rule files ...
> Undefined symbol PTXCONF_BLSPEC_RPI4 used in 'DistroKit/rules/blspec-rpi4.make'.
> [...]
> 
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> ---
>  {rules => configs/platform-v7a/rules}/blspec-rpi4.make | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename {rules => configs/platform-v7a/rules}/blspec-rpi4.make (100%)
> 
> diff --git a/rules/blspec-rpi4.make b/configs/platform-v7a/rules/blspec-rpi4.make
> similarity index 100%
> rename from rules/blspec-rpi4.make
> rename to configs/platform-v7a/rules/blspec-rpi4.mak

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2022-12-12 17:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12  8:23 Michael Olbrich
2022-12-12 17:06 ` Ahmad Fatoum [this message]
2022-12-12 19:06   ` Michael Olbrich
2023-01-06 11:39     ` [DistroKit] [PATCH] blspec-rpi4: move menu file to platforms/ Michael Olbrich
2023-01-06 11:46       ` Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19b5fa1c-cb99-8cc8-268e-71bb1f7d894f@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    --cc=m.olbrich@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox