Re: [DistroKit] [ptxdist] Recent DistroKit with ptxdist 2018.10.0 fails to get host-coreutils

[Roland Hieber <r.hieber@pengutronix.de>]

On Wed, Oct 10, 2018 at 03:22:13PM +0200, Alexander Dahl wrote:
> Hei hei,
> 
> On Wed, Oct 10, 2018 at 02:21:48PM +0200, Roland Hieber wrote:
> > On Wed, Oct 10, 2018 at 01:04:01PM +0200, Roland Hieber wrote:
> > > Ohai,
> > > 
> > > I set my source download folder to ./src/ and I can reproduce this with
> > > various other packages as well (kernel, coreutils, systemd,
> > > networkmanager), and even on PTXdist 2018.01.0…?!
> 
> I don't think that is the same problem. I set PTXCONF_SETUP_SRCDIR to
> /mnt/trash/src first, and to the default ${PTXDIST_WORKSPACE}/src
> then. The problem is reproducible for packages where you build the
> host, but not the target package, e.g. FOO=n and HOST_FOO=y. For
> DistroKit master that is the case for acl, coreutils and maybe more.

Indeed, I can also reproduce this with ${PTXDIST_WORKSPACE}/src. I guess
HOST_* packages are missing the mapping from the HOST_*_SOURCE to the
*_SOURCE variables, but I cannot see right now where and when this
broke. I'll try a bisect later today.

 - Roland

> 
> > > I added some debug echos to ptxdist/rules/post/ptxd_make_world_get.make:
> > > 
> > > ------------------------------------------------ 8<---------------------
> > > --- a/rules/post/ptxd_make_world_get.make
> > > +++ b/rules/post/ptxd_make_world_get.make
> > > @@ -15,7 +15,8 @@
> > >  #
> > >  $(SRCDIR)/%:
> > >         →@$(call targetinfo)
> > > -       →@$(call get, $($@))
> > > +       →echo target '$$(SRCDIR)/%'; echo params: $@; echo $$($$@) = $($@); set -x; \
> > > +       →$(call get, $($@))
> > >  
> > >  ifneq ($(call remove_quotes, $(PTXCONF_PROJECT_DEVPKGDIR)),)
> > >  $(call remove_quotes, $(PTXCONF_PROJECT_DEVPKGDIR))/%-dev.tar.gz:
> > > ------------------------------------------------ >8---------------------
> 
> Nice. Let me show you two example outputs from my side, first is from
> a usual target only package, second triggers the problem:
> 
> --------------------------
> target: glib-2.56.1.tar.xz
> --------------------------
> 
> echo target '$(SRCDIR)/%'; echo params: /home/alex/src/DistroKit/src/glib-2.56.1.tar.xz; echo $($@) = GLIB; set -x; \
> ptxd_make_get_mirror=http://www.pengutronix.de/software/ptxdist/temporary-src ptxd_make_get "/home/alex/src/DistroKit/src/glib-2.56.1.tar.xz" "http://ftp.gnome.o
> rg/pub/GNOME/sources/glib/2.56/glib-2.56.1.tar.xz"
> target $(SRCDIR)/%
> params: /home/alex/src/DistroKit/src/glib-2.56.1.tar.xz
> = GLIB
> 
> 
> -----------------------------
> target: acl-2.2.52.src.tar.gz
> -----------------------------
> 
> echo target '$(SRCDIR)/%'; echo params: /home/alex/src/DistroKit/src/acl-2.2.52.src.tar.gz; echo $($@) = ; set -x; \
> ptxd_make_get_mirror=http://www.pengutronix.de/software/ptxdist/temporary-src ptxd_make_get "" ""
> target $(SRCDIR)/%
> params: /home/alex/src/DistroKit/src/acl-2.2.52.src.tar.gz
> =
> 
> > > I think that the $($@) expression should result in "NETWORKMANAGER", so
> > > ptxd_make_get knows about what package to download. As far as I
> > > understand, this should be a generated rule in
> > > DistroKit/platform-$name/state/ptxd_dgen_deps.post, but I cannot find it
> > > there... I'll try a bisect on ptxdist to find out where it first went
> > > wrong.
> 
> If I compare the above output, the same happens here. In the second
> case ACL is missing while in the first case GLIB is there.
> 
> I could reproduce this on another build host.
> 
> So to say it clear again: download of a tarball fails, if the host
> package is selected, but the normal target package is not. If the
> tarball is already there, build is successful.
> 
> Greets
> Alex
> 
> -- 
> /"\ ASCII RIBBON | »With the first link, the chain is forged. The first
> \ / CAMPAIGN     | speech censured, the first thought forbidden, the
>  X  AGAINST      | first freedom denied, chains us all irrevocably.«
> / \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)



> _______________________________________________
> DistroKit mailing list
> DistroKit@pengutronix.de


-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de