Re: [DistroKit] [ptxdist] Recent DistroKit with ptxdist 2018.10.0 fails to get host-coreutils

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Oct 11, 2018 at 10:05:56PM +0200, Roland Hieber wrote:
> On Thu, Oct 11, 2018 at 04:28:43PM +0200, Roland Hieber wrote:
> > On Wed, Oct 10, 2018 at 03:22:13PM +0200, Alexander Dahl wrote:
> > > On Wed, Oct 10, 2018 at 02:21:48PM +0200, Roland Hieber wrote:
> > > > On Wed, Oct 10, 2018 at 01:04:01PM +0200, Roland Hieber wrote:
> > > [...] I set PTXCONF_SETUP_SRCDIR to
> > > /mnt/trash/src first, and to the default ${PTXDIST_WORKSPACE}/src
> > > then. The problem is reproducible for packages where you build the
> > > host, but not the target package, e.g. FOO=n and HOST_FOO=y. For
> > > DistroKit master that is the case for acl, coreutils and maybe more.
> > 
> > Indeed, I can also reproduce this with ${PTXDIST_WORKSPACE}/src. I guess
> > HOST_* packages are missing the mapping from the HOST_*_SOURCE to the
> > *_SOURCE variables, but I cannot see right now where and when this
> > broke. I'll try a bisect later today.
> 
> I did a git bisect run with a script that deletes $SRCDIR/coreutils*
> followed by ptxdist get host-coreutils. It results in commit 400bee10 [a]
> as the first commit which no longer downloads coreutils*tar.gz and only
> prints "error: empty parameter to 'ptxd_make_get'". That commit
> unfortunately landed in ptxdist-2018.10.0.
> 
> I'm not so versed in the inner workings of ptxd_lib_dgen.awk - mol, do
> you have an idea what needs to be done here? It looks to me that if we
> don't want to reintroduce the $(<PKG>_SOURCE) := <PKG> variables, we need to
> teach the '$(SRCDIR)/%' target [b] how to infer the HOST_<PKG> prefix
> from the source archive name, even if <pkg> is not selected. But I have
> no idea how to do that.

The problem is, that '$(<PKG>_SOURCE) := <PKG>' is not set for the target
package because it's disabled. And it's not set for the host package
because they share the source (that condition was introduced in the commit
you found).
The solution is to define '$(<PKG>_SOURCE) := <PKG>' for the host package
if the target package is disabled. This should be fixed in master.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de