From: Roland Hieber <rhi@pengutronix.de>
To: Robert Schwebel <r.schwebel@pengutronix.de>
Cc: Michael Olbrich <m.olbrich@pengutronix.de>,
distrokit@pengutronix.de, Alexander Dahl <post@lespocky.de>,
Rouven Czerwinski <rcz@pengutronix.de>
Subject: [DistroKit] [PATCH v2] v7a: image-vexpress: fix comment in image config
Date: Mon, 11 Feb 2019 17:18:24 +0100 [thread overview]
Message-ID: <20190211161824.b4ydsnece3kyuu3i@pengutronix.de> (raw)
In-Reply-To: <20190211133303.chkparebct5sfxfx@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
On Mon, Feb 11, 2019 at 02:33:03PM +0100, Robert Schwebel wrote:
> Applied to next.
>
> rsc
Ah, mol just explained the reason to me. Robert, please drop my previous
patch in favor of the following:
---
configs/platform-v7a/config/images/vexpress.config | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/configs/platform-v7a/config/images/vexpress.config b/configs/platform-v7a/config/images/vexpress.config
index 7cfaaaa..1eed95d 100644
--- a/configs/platform-v7a/config/images/vexpress.config
+++ b/configs/platform-v7a/config/images/vexpress.config
@@ -12,7 +12,11 @@ image @IMAGE@ {
partition-type = 0x83
size = 512M
}
- /* expand image size to 64 MiB; dummy size, results in 0 bytes length */
+ /* genimage does not write zeros at the end of an image to save space,
+ * but the kernel in qemu will complain if the image file is smaller
+ * than the partition sizes. work around this by adding an empty
+ * partition at the end.
+ */
partition end {
image = /dev/null
size = 1M
--
2.20.1
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
next prev parent reply other threads:[~2019-02-11 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 13:29 [DistroKit] [PATCH] v7a: image-vexpress: remove unneeded partition Roland Hieber
2019-02-11 13:33 ` Robert Schwebel
2019-02-11 14:46 ` Michael Olbrich
2019-02-11 15:06 ` Robert Schwebel
2019-02-11 16:18 ` Roland Hieber [this message]
2019-02-12 6:30 ` [DistroKit] [PATCH v2] v7a: image-vexpress: fix comment in image config Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211161824.b4ydsnece3kyuu3i@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=distrokit@pengutronix.de \
--cc=m.olbrich@pengutronix.de \
--cc=post@lespocky.de \
--cc=r.schwebel@pengutronix.de \
--cc=rcz@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox