DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: distrokit@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [DistroKit] [PATCH v2 2/9] pre/barebox: barebox-url: only use <PKG>_VERSION to build the URL
Date: Wed,  5 Jun 2019 20:52:06 +0200	[thread overview]
Message-ID: <20190605185213.26698-2-rhi@pengutronix.de> (raw)
In-Reply-To: <20190605185213.26698-1-rhi@pengutronix.de>

When adding another barebox package to a BSP, e.g. named barebox-foo,
the BAREBOX_FOO variable will contain "barebox-foo-$(VERSION)". This
variable is used to build BAREBOX_DIR, BAREBOX_SOURCE, and
BAREBOX_FOO_URL.

We must to keep the customized package postfix in the build
directory, but in the latter case, the -foo postfix is transferred
into the URL, which will lead to errors while downloading the source.

We actually only need the barebox version to download the source
tarball, so use a static "barebox-" string to build the barebox/url
macro and also the BAREBOX_FOO_SOURCE variable in the package template,
so the same tarball isn't downloaded multiple times with different
names.

Forwarded: https://www.mail-archive.com/ptxdist@pengutronix.de/msg14535.html
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---

Notes:
    Changes in v1 -> v2:
    - this patch is new in v2
    - import from upstream to fix BAREBOX_COMMON_URL

 rules/pre/barebox.make | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 rules/pre/barebox.make

diff --git a/rules/pre/barebox.make b/rules/pre/barebox.make
new file mode 100644
index 000000000000..8979afafd2e5
--- /dev/null
+++ b/rules/pre/barebox.make
@@ -0,0 +1,6 @@
+# backport of PTXdist patch https://www.mail-archive.com/ptxdist@pengutronix.de/msg14535.html
+# This file can be removed after the patch has gone upstream
+barebox/url = \
+	http://www.barebox.org/download/barebox-$($(1)_VERSION).$($(1)_SUFFIX)
+
+# vim: syntax=make
-- 
2.20.1


_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de

  reply	other threads:[~2019-06-05 18:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 18:52 [DistroKit] [PATCH v2 1/9] v7a: remove unused barebox_mlo menu entry Roland Hieber
2019-06-05 18:52 ` Roland Hieber [this message]
2019-06-05 21:46   ` [DistroKit] [PATCH v2 2/9] pre/barebox: barebox-url: only use <PKG>_VERSION to build the URL Robert Schwebel
2019-06-05 18:52 ` [DistroKit] [PATCH v2 3/9] v7a: barebox-common: add a common reference config for all barebox variants Roland Hieber
2019-06-05 19:05   ` [DistroKit] [PATCH v2] fixup! " Roland Hieber
2019-06-05 21:47     ` Robert Schwebel
2019-06-05 18:52 ` [DistroKit] [PATCH v2 4/9] v7a: bareboxes: use shared settings from the barebox-common package Roland Hieber
2019-06-05 21:47   ` Robert Schwebel
2019-06-05 18:52 ` [DistroKit] [PATCH v2 5/9] v7a: bareboxes: use config diffs with the common reference config Roland Hieber
2019-06-05 21:48   ` Robert Schwebel
2019-06-05 18:52 ` [DistroKit] [PATCH v2 6/9] v7a: barebox-am335x: slim down config diff Roland Hieber
2019-06-05 21:48   ` Robert Schwebel
2019-06-05 18:52 ` [DistroKit] [PATCH v2 7/9] v7a: barebox-mx6: " Roland Hieber
2019-06-05 21:48   ` Robert Schwebel
2019-06-05 18:52 ` [DistroKit] [PATCH v2 8/9] v7a: barebox-rpi2: " Roland Hieber
2019-06-05 21:49   ` Robert Schwebel
2019-06-05 18:52 ` [DistroKit] [PATCH v2 9/9] v7a: barebox-vexpress: " Roland Hieber
2019-06-05 21:49   ` Robert Schwebel
2019-06-05 21:46 ` [DistroKit] [PATCH v2 1/9] v7a: remove unused barebox_mlo menu entry Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605185213.26698-2-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox