From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jF0sq-0006pi-NT for distrokit@pengutronix.de; Thu, 19 Mar 2020 20:31:12 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jF0sq-0005K0-EY for distrokit@pengutronix.de; Thu, 19 Mar 2020 20:31:12 +0100 Date: Thu, 19 Mar 2020 20:31:12 +0100 From: Michael Olbrich Message-ID: <20200319193112.GH2448@pengutronix.de> References: <20200314130506.19889-1-post@lespocky.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [DistroKit] [PATCH] tf-a: Add missing dependency to host dtc List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: distrokit-bounces@pengutronix.de Sender: "DistroKit" To: distrokit@pengutronix.de On Thu, Mar 19, 2020 at 05:28:47PM +0100, Ahmad Fatoum wrote: > On 3/14/20 2:05 PM, Alexander Dahl wrote: > > Build after clean all failed like this: > > > > /bin/sh: 1: dtc: not found > > dtc version too old (), you need at least version 1.4.4 > > > > A quick inspection of the tf-a source showed dtc is only needed for > > stm32 when TF_A_EXTRA_ARGS is used, like it is done currently in > > DistroKit, so a global dependency might be to broad. However dtc is > > probably needed for arm targets anyway, so it should not hurt that > > much?! > > It's needed for few other platforms that use device tree as well, > but most don't use it. > I also that think enabling it unconditionally is ok. What about an option? Similar to the BAREBOX_NEEDS_* options. Michael > I'll include your change in my v5 for the upstream tf-a rule, > Thanks! > > > Signed-off-by: Alexander Dahl > > Reviewed-by: Ahmad Fatoum > > > --- > > rules/tf-a.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/rules/tf-a.in b/rules/tf-a.in > > index 3cddf79..ba04f44 100644 > > --- a/rules/tf-a.in > > +++ b/rules/tf-a.in > > @@ -2,6 +2,7 @@ > > > > menuconfig TF_A > > select BOOTLOADER > > + select HOST_DTC > > prompt "ARM Trusted Firmware-A " > > depends on ARCH_ARM || ARCH_ARM64 > > bool > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > _______________________________________________ > DistroKit mailing list > DistroKit@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ DistroKit mailing list DistroKit@pengutronix.de