Re: [DistroKit] [PATCH v1 3/3] MIPS: kernel: malta: remove flash partition table

[Oleksij Rempel <o.rempel@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 3941 bytes --]

On Fri, May 15, 2020 at 09:42:42AM +0200, Ahmad Fatoum wrote:
> Hello Oleksij,
> 
> On 4/28/20 7:47 PM, Oleksij Rempel wrote:
> > it should be provided by the bootloader
> 
> barebox already deletes an existing partitions node on fixup, see of_partition_fixup().
> Does this not work for you?

It is just warning made by analyzer. And in most cases it is indeed a bad
idea to put project configuration in to a mainline kernel dts.

> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  ...2-MIPS-malta-remove-fixed-partitions.patch | 45 +++++++++++++++++++
> >  .../platform-mips/patches/linux-5.6.2/series  |  3 +-
> >  2 files changed, 47 insertions(+), 1 deletion(-)
> >  create mode 100644 configs/platform-mips/patches/linux-5.6.2/0002-MIPS-malta-remove-fixed-partitions.patch
> > 
> > diff --git a/configs/platform-mips/patches/linux-5.6.2/0002-MIPS-malta-remove-fixed-partitions.patch b/configs/platform-mips/patches/linux-5.6.2/0002-MIPS-malta-remove-fixed-partitions.patch
> > new file mode 100644
> > index 0000000..a920a4b
> > --- /dev/null
> > +++ b/configs/platform-mips/patches/linux-5.6.2/0002-MIPS-malta-remove-fixed-partitions.patch
> > @@ -0,0 +1,45 @@
> > +From: Oleksij Rempel <o.rempel@pengutronix.de>
> > +Date: Tue, 28 Apr 2020 14:55:25 +0200
> > +Subject: [PATCH] MIPS: malta: remove fixed partitions
> > +
> > +this partition table should be provided by the bootloader
> > +
> > +Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > +---
> > + arch/mips/boot/dts/mti/malta.dts | 23 -----------------------
> > + 1 file changed, 23 deletions(-)
> > +
> > +diff --git a/arch/mips/boot/dts/mti/malta.dts b/arch/mips/boot/dts/mti/malta.dts
> > +index f03279b1cde7..7642a7c53a3a 100644
> > +--- a/arch/mips/boot/dts/mti/malta.dts
> > ++++ b/arch/mips/boot/dts/mti/malta.dts
> > +@@ -57,29 +57,6 @@ flash@1e000000 {
> > + 		bank-width = <4>;
> > + 		#address-cells = <1>;
> > + 		#size-cells = <1>;
> > +-
> > +-		partitions {
> > +-			compatible = "fixed-partitions";
> > +-			#address-cells = <1>;
> > +-			#size-cells = <1>;
> > +-
> > +-			yamon@0 {
> > +-				label = "YAMON";
> > +-				reg = <0x0 0x100000>;
> > +-				read-only;
> > +-			};
> > +-
> > +-			user-fs@100000 {
> > +-				label = "User FS";
> > +-				reg = <0x100000 0x2e0000>;
> > +-			};
> > +-
> > +-			board-config@3e0000 {
> > +-				label = "Board Config";
> > +-				reg = <0x3e0000 0x20000>;
> > +-				read-only;
> > +-			};
> > +-		};
> > + 	};
> > + 
> > + 	fpga_regs: system-controller@1f000000 {
> > diff --git a/configs/platform-mips/patches/linux-5.6.2/series b/configs/platform-mips/patches/linux-5.6.2/series
> > index dadc772..a885d05 100644
> > --- a/configs/platform-mips/patches/linux-5.6.2/series
> > +++ b/configs/platform-mips/patches/linux-5.6.2/series
> > @@ -1,4 +1,5 @@
> >  # generated by git-ptx-patches
> >  #tag:base --start-number 1
> >  0001-HACK-MIPS-disable-bogus-code.patch
> > -# 1aabf59e6345434460b53d6d21377e5e  - git-ptx-patches magic
> > +0002-MIPS-malta-remove-fixed-partitions.patch
> > +# 598cc0167d4c33db68cf711e58479093  - git-ptx-patches magic
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> DistroKit mailing list
> DistroKit@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 96 bytes --]

_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de